Skip to content

fix(shared): compare prerelease versions without locale or precision loss #32169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luke2x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shared): compare prerelease versions without locale or precision loss #32169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/shared/src/semver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ describe("semver helpers", () => {
});

it("compares prerelease versions before stable versions", () => {
expect(compareSemverVersions("1.0.0-Z", "1.0.0-a")).toBeLessThan(0);
expect(compareSemverVersions("1.0.0-alpha-1", "1.0.0-alpha1")).toBeLessThan(0);
expect(compareSemverVersions("1.0.0-9007199254740992", "1.0.0-9007199254740993")).toBeLessThan(
0,
);
expect(compareSemverVersions("2.1.111-beta.1", "2.1.111")).toBeLessThan(0);
});

Expand Down
6 changes: 4 additions & 2 deletions packages/shared/src/semver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,17 @@ function comparePrereleaseIdentifier(left: string, right: string): number {
const rightNumeric = SEMVER_NUMBER_SEGMENT.test(right);

if (leftNumeric && rightNumeric) {
return Number.parseInt(left, 10) - Number.parseInt(right, 10);
const leftNumber = BigInt(left);
const rightNumber = BigInt(right);
return leftNumber === rightNumber ? 0 : leftNumber < rightNumber ? -1 : 1;
}
if (leftNumeric) {
return -1;
}
if (rightNumeric) {
return 1;
}
return left.localeCompare(right);
return left === right ? 0 : left < right ? -1 : 1;
}

export function compareSemverVersions(left: string, right: string): number {
Expand Down
Loading