Skip to content

[fix/feat:ui] Preserve open-in editor brand colors - #3225

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-open-in-brand-icon-colors
Jul 18, 2026
Merged

[fix/feat:ui] Preserve open-in editor brand colors#3225
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-open-in-brand-icon-colors

Conversation

@sandersonstabo

@sandersonstabo sandersonstabo commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

What changed

Editor icons in the open-in picker now keep their intended brand color in both the trigger and dropdown. Generic file manager entries stay muted.

Why

Zed and GitHub-style editor icons were readable in one place and muted in another. The picker now applies one brand-versus-generic icon rule everywhere.

UI changes

Before:

Before

After:

After

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Testing

vp check; vp run typecheck passed locally before splitting these PRs.

Note

Preserve brand colors for editor icons in OpenInPicker

Adds a kind field ('brand' | 'generic') to each option in OpenInPicker.tsx. A new getOpenInIconClass helper applies text-foreground opacity-100 to brand editor icons and text-muted-foreground to the generic file manager icon, replacing the previously uniform muted styling.

Macroscope summarized a769fce.


Note

Low Risk
Presentation-only class changes in the open-in picker; no editor launch or preference logic is modified.

Overview
Open-in picker icons now distinguish brand editors from the generic file manager entry using a shared styling rule on both the primary button and the dropdown.

Each resolved option gets a kind of brand or generic. A new getOpenInIconClass helper applies text-foreground opacity-100 for brand icons and text-muted-foreground for the Finder/Explorer/Files option, replacing the previous behavior where menu icons were always muted and the trigger icon had no consistent color treatment.

Reviewed by Cursor Bugbot for commit a769fce. Bugbot is set up for automated code reviews on this repo. Configure here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants