[fix/feat:ui] Preserve open-in editor brand colors - #3225
Merged
juliusmarminge merged 2 commits intoJul 18, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Editor icons in the open-in picker now keep their intended brand color in both the trigger and dropdown. Generic file manager entries stay muted.
Why
Zed and GitHub-style editor icons were readable in one place and muted in another. The picker now applies one brand-versus-generic icon rule everywhere.
UI changes
Before:
After:
Checklist
Testing
vp check;vp run typecheckpassed locally before splitting these PRs.Note
Preserve brand colors for editor icons in
OpenInPickerAdds a
kindfield ('brand'|'generic') to each option in OpenInPicker.tsx. A newgetOpenInIconClasshelper appliestext-foreground opacity-100to brand editor icons andtext-muted-foregroundto the generic file manager icon, replacing the previously uniform muted styling.Macroscope summarized a769fce.
Note
Low Risk
Presentation-only class changes in the open-in picker; no editor launch or preference logic is modified.
Overview
Open-in picker icons now distinguish brand editors from the generic file manager entry using a shared styling rule on both the primary button and the dropdown.
Each resolved option gets a
kindofbrandorgeneric. A newgetOpenInIconClasshelper appliestext-foreground opacity-100for brand icons andtext-muted-foregroundfor the Finder/Explorer/Files option, replacing the previous behavior where menu icons were always muted and the trigger icon had no consistent color treatment.Reviewed by Cursor Bugbot for commit a769fce. Bugbot is set up for automated code reviews on this repo. Configure here.