[only21mil]

Problem

Settings > Providers > Claude > Auto-compact after accepts any text. A value outside 100,000 to 1,000,000, such as 50000, 300k or 300,000, saves with no error, and then the Claude instance shows as Disabled ("Invalid config for instance 'claudeAgent': Expected a string matching the RegExp …"), reports no models, and new Claude threads on it cannot start until the user finds and clears the field.

Change

The field schema already says what is valid (TrimmedString.check(Schema.isPattern(...)) in packages/contracts/src/settings.ts); the settings form never checked it before saving. deriveProviderSettingsFields now gives each field an isValid(value) built from its own schema, and ProviderSettingsTextInput commits only values that pass. A rejected value stays in the field with aria-invalid and "Enter a valid value.", and is never sent to the server. The Add provider dialog renders the same form, so it gets the same check.

Scope

Bug fix: one wrong keystroke in one settings field disables the Claude provider. Fixes #35041. I found no other open or closed PR or issue covering it. Not in this PR: the server still accepts an invalid instance config from other clients.

Verification

To see it on Linux web on main: open Settings > Providers > Claude, type 300k into Auto-compact after, press Enter. Claude turns Disabled with the invalid-config error.

Run today on main 01b815ffc2, this head e79f54f5e2, and the head merged locally with that main as 0e134479fd (not pushed), each T3 server from source as "Test machine" with a fresh home, --no-seed, a placeholder ANTHROPIC_API_KEY and no Claude account. Web input was typed in T3's Browser panel; desktop input was sent through the Electron debugging port. The PR's tests fail on main's form (2 failed, 6 passed) and pass on the head and merged tree (8 passed). On main 300k saves ({"autoCompactWindow":"300k"}) and Claude turns Disabled; on the head and merged tree it is rejected in the field, nothing is saved, and Claude stays authenticated.

Web on main 01b815f: Claude Disabled with the invalid-config error after 300k

Web on the head e79f54f: 300k outlined red with "Enter a valid value.", Claude Authenticated

Not checked: screen reader output (aria-invalid is in the step log). Mobile has no editor for this field.

Desktop and merged-tree captures, other values, change detail and unedited output

Steps on main: open Settings > Providers > Claude, type 300k into Auto-compact after, press Enter. The server stores the instance config as typed, then fails to decode it when it starts the provider.

Change detail: isValid decodes the value the way the server does, so surrounding spaces still pass. An empty value stays valid where the field is dropped when empty. A rejected value is linked to the short "Enter a valid value." line. Entering a valid value or clearing the field removes the error. So does a new saved value arriving from elsewhere, such as another device. This works for any provider field with a schema check, not just this one. Today only autoCompactWindow has one, so no other field changes behavior. In the Add provider dialog a rejected value is left out of the new instance while the field shows the error. It adds no setting and changes no valid behavior. Decoding an invalid instance config in updateProviderInstance would be a separate hardening fix.

Desktop on main 01b815f: Claude Disabled with the invalid-config error after 300k

Desktop on the head e79f54f: 300k outlined red with "Enter a valid value.", Claude Authenticated

Web on the merged tree 0e134479fd: 300k outlined red with "Enter a valid value.", Claude Authenticated

Head e79f54f5e2: 50000 and 300,000 are rejected the same way; 300000, 1000000 and 300000 save, and clearing removes the setting.

Head e79f54f: 300000 in the field, no error, Claude Authenticated

Head e79f54f5e2: with 300k rejected, writing 500000 to the settings file replaces it and clears the error.

Head e79f54f: the field shows 500000 with no error after the settings file changed

Head e79f54f5e2: in the Add provider dialog 300k is rejected, and the new Claude instance is created without it.

Head e79f54f, Add provider dialog: 300k outlined red with "Enter a valid value."

Tests on main (the PR's test files with main's form), the head, the merged tree:

$ grep -E '^ FAIL|^(AssertionError|Error):|Test Files|Tests  ' tests-main.clean.txt
 FAIL  |unit| src/components/settings/ProviderSettingsForm.test.ts > ProviderSettingsForm helpers > accepts only text values the field schema decodes
AssertionError: expected undefined to be defined
 FAIL  |browser (chromium)| src/components/settings/ProviderSettingsForm.browser.test.tsx > ProviderSettingsForm text fields > drops a rejected draft once the saved value changes
Error: expect(element).toHaveValue(300k)
 Test Files  2 failed (2)
      Tests  2 failed | 6 passed (8)

$ grep -E '^ FAIL|^(AssertionError|Error):|Test Files|Tests  ' tests-head.clean.txt
 Test Files  2 passed (2)
      Tests  8 passed (8)

$ grep -E '^ FAIL|^(AssertionError|Error):|Test Files|Tests  ' tests-merged.clean.txt
 Test Files  2 passed (2)
      Tests  8 passed (8)

Saved settings after 300k: web on main, desktop on main, web on the head, desktop on the head, the merged tree:

$ jq -c '.providerInstances.claudeAgent' userdata/settings.json   # main 01b815ffc2, after typing 300k + Enter
{"driver":"claudeAgent","config":{"autoCompactWindow":"300k"}}

# desktop (Electron), main 01b815ffc2, after typing 300k + Enter
$ jq -c '.providerInstances.claudeAgent' userdata/settings.json
{"driver":"claudeAgent","config":{"autoCompactWindow":"300k"}}

# head e79f54f5e2, after typing 300k + Enter
$ jq -c '.providerInstances | keys' userdata/settings.json
["devReplay"]
$ jq -c '.providerInstances.claudeAgent' userdata/settings.json
null

# desktop (Electron), head e79f54f5e2, after typing 300k + Enter
$ ls userdata/settings.json
ls: cannot access 'userdata/settings.json': No such file or directory

# head e79f54f5e2 merged locally with main 01b815ffc2 (merge 0e134479fd, not pushed), after typing 300k + Enter
$ jq -c '.providerInstances | keys' userdata/settings.json
["devReplay"]
$ jq -c '.providerInstances.claudeAgent' userdata/settings.json
null

Every value on the head, in order (field state read from the page, saved value read from the test server's settings file):

{"step":"head: type 50000, Enter","panel":{"field":"50000","ariaInvalid":"true","error":"Enter a valid value."},"saved":null}
{"step":"head: type 300,000, Enter","panel":{"field":"300,000","ariaInvalid":"true","error":"Enter a valid value."},"saved":null}
{"step":"head: type \" 300000 \" (spaces around), Enter","panel":{"field":" 300000 ","ariaInvalid":"false","error":null},"saved":{"autoCompactWindow":" 300000 "}}
{"step":"head: type 1000000, Enter","panel":{"field":"1000000","ariaInvalid":"false","error":null},"saved":{"autoCompactWindow":"1000000"}}
{"step":"head: type \" 300000 \" again, Enter, then Refresh provider status","panel":{"field":" 300000 ","ariaInvalid":"false","error":null,"claudeCard":"Claude v2.1.322 Authenticated"},"saved":{"autoCompactWindow":" 300000 "}}
{"step":"head: type 300k, Enter (saved value is \" 300000 \")","panel":{"field":"300k","ariaInvalid":"true","error":"Enter a valid value."},"saved":{"autoCompactWindow":" 300000 "}}
{"step":"head: after the settings file write of 500000","panel":{"field":"500000","ariaInvalid":"false","error":null},"saved":{"autoCompactWindow":"500000"}}
{"step":"head: clear the field, Enter","panel":{"field":"","ariaInvalid":"false","error":null},"saved":null}
{"step":"head: type 300000, Enter, then Refresh provider status","panel":{"field":"300000","ariaInvalid":"false","error":null,"claudeCard":"Claude v2.1.322 Authenticated"},"saved":{"autoCompactWindow":"300000"}}

The settings file write, and the Add provider result:

$ jq '.providerInstances.claudeAgent.config.autoCompactWindow = "500000"' userdata/settings.json  # written to the test server's settings file while 300k shows rejected
{"autoCompactWindow":"500000"}

# head e79f54f5e2, after Add provider > Claude with 300k in Auto-compact after (rejected in the field), then Add instance
$ jq -c '.providerInstances | with_entries(select(.value.driver == "claudeAgent"))' userdata/settings.json
{"claudeAgent":{"driver":"claudeAgent","config":{"autoCompactWindow":"300000"}},"claudeAgent_2":{"driver":"claudeAgent","displayName":"Claude","enabled":true}}

Generated with Claude Opus 5.5 in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — Provider settings text inputs now keep invalid values local and show an inline error instead of saving them. The stale-draft finding remains subject to the separate blocking gate; the remaining change presents no material operational or product-policy risk.

Needs human approval because:

• 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Provider settings text fields now validate committed drafts against their field schemas. Invalid drafts remain visible with an error state and do not update configuration. Valid drafts update configuration.

Changes: Provider text validation

Layer / File(s)	Summary
Schema-based field validation apps/web/src/components/settings/ProviderSettingsForm.tsx, apps/web/src/components/settings/ProviderSettingsForm.test.ts	The field model exposes a schema-based text validator and an effective empty-value policy. Tests cover valid and invalid autoCompactWindow values.
Validated text input apps/web/src/components/settings/ProviderSettingsForm.tsx, apps/web/src/components/settings/ProviderSettingsForm.browser.test.tsx	The settings-variant text control validates committed drafts. Invalid drafts remain visible with an error state and do not update configuration. The browser test checks input and invalid-state updates when saved values change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#32382: Moves the field model and derivation helpers to a shared package, so the isValid contract may need to be carried into the relocated implementation.

Suggested labels: bugfix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to e79f5

Invalid values such as "300k" are now rejected in the provider settings field and in the Add provider dialog, so they no longer reach the config. No actionable merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: the Auto-compact after field now rejects invalid values in the field instead of saving them and taking Claude offline. The raw summary covers validation in ProviderSet…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description follows the repository template closely. It has all five sections: Problem, Change, Scope, Verification, and the agent attribution line. The Problem section states the expected behavio…

Full details: Title check

Explanation

The title names the main change: the Auto-compact after field now rejects invalid values in the field instead of saving them and taking Claude offline. The raw summary covers validation in ProviderSettingsForm, a new isValid property, the text input error handling, and tests, which match the title. The title does use the conventional commit form with a plain-language description.

Full details: Description check

Explanation

The description follows the repository template closely. It has all five sections: Problem, Change, Scope, Verification, and the agent attribution line. The Problem section states the expected behavior and reproduction steps. The Change section explains how the schema-derived isValid check fixes the issue. The Scope section is a bug fix with a linked issue (#35041) and a note on what is excluded. The Verification section gives reproduction steps, before and after screenshots, test output on main, the head, and the merged tree, and lists what was not checked. The template's Verification guidance asks for focused checks and observed results, and the author supplies them. The author also includes the model and harness attribution. The only minor gap is the Scope section, which does not state whether a maintainer requested the PR. That is not a critical omission. The description is complete enough to pass.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 25bf84a
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2ec42aac-3a19-4605-a377-f832a9953621

Commits

Reviewing files that changed from the base of the PR and between 85c1999 and e79f54f.

Files selected for processing: 2

• apps/web/src/components/settings/ProviderSettingsForm.browser.test.tsx
• apps/web/src/components/settings/ProviderSettingsForm.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified unchanged head e79f54f5e299a1e939e317e1737e0f473a4cc397 on linux using the real dev web app, repository playwright, and /usr/bin/google-chrome. main and the pr ran sequentially with isolated state. no mocks or seeded/demo data.

• reproduced on current github/main (6c9adfb273): enter 300k, refresh provider status. the server saved it, claude became disabled with an invalid-config error, and reported zero models.
• on this head, 50000, 300,000, and 300k stay local with the linked validation error. enter and blur both reject invalid input; saved config stays unchanged.
• 300000, surrounding spaces, and 1000000 save. clearing removes the setting. a second web client changing the saved value 300000 → 500000 → 300000 clears the rejected draft permanently.
• add-provider wizard: a real claude instance created with rejected 300k omitted that setting and avoided invalid-config status.
• added a project pointing at a real git checkout through the app, created a thread, selected codex gpt-6.1-sol, and completed a real provider turn that read the repository's package name.
• blacksmith vp run check:changed 25bf84ab07f53f141c20239c63e383823a9d5ea0 passed format, lint, knip, affected typechecks, all 8 focused tests, and react compiler. no code changes needed.

short runtime transcript

Not verified

an authenticated claude turn and actual token-threshold compaction: claude is installed but has no login on this vm. native desktop/mobile clients, screen-reader speech, and remote/tunnel connections were not exercised. invalid writes from other clients remain outside this web-only fix.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

Thank you for testing this end to end. Reproducing on main that 300k takes Claude offline with zero models, then showing that on this head 50000, 300,000 and 300k stay in the field with the error while valid values, spaces and clearing still save, covers what the change is for. The second-client check, where a saved-value change clears the rejected draft, and the add-provider wizard case go beyond the settings field itself. You're right that an authenticated Claude turn with real compaction wasn't exercised, and that invalid values written by other clients are outside this web-only fix.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

Main fixes this as of b2e86d7 (#35100): an invalid Auto-compact after value is now refused in the field and Claude stays available, so I am closing this PR.