You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): open documents no longer reload after every agent command - #32693
An open Word, PowerPoint or other document/binary preview in the Files panel reloads and jumps back to its first page after every agent command and checkpoint, even when that file did not change. The document branch of FilePreviewPanel keyed AttachmentFilePreview on the thread-wide workspaceMutationId, which moves after every completed command, file change and checkpoint.
Reproduced on main @ 25bf84a in the web app (fresh database, synthetic files): a 21-page report.docx scrolled to 2500px was torn down and reloaded at page 1 three times while the agent ran sleep 5; echo one and sleep 5; echo two (two commands plus the checkpoint), with the file untouched. A 400-row data.sqlite preview did the same on a single git status turn (scroll 966 → 0, twice).
Change
The document branch now goes through a small WorkspaceDocumentPreview that reads the server's fileRevision for the media-file asset with useAssetUrlState, the same way the video, audio, PDF and large-text previews already do, and remounts AttachmentFilePreview only when that revision (or the explicit refresh) changes.
An unchanged file stays mounted, keeping its page and scroll position.
A real edit gives a new revision, so the new bytes load.
While the revision is re-checked (including a reconnect, which reports Loading), the last revision is kept; the first open shows the loading state until the revision arrives, so the preview mounts once.
A failed mint (the file was deleted or moved) remounts so the preview shows its error.
Servers that report no fileRevision keep following workspaceMutationId as before. In a draft, recognized documents (served as draft-workspace-file) also keep following workspaceMutationId; draft unknown binaries are media-file assets and follow their file revision like any other.
Triaged bug report; one-branch fix in apps/web/src/components/files/FilePreviewPanel.tsx plus its browser test. HTML, image and PDF previews are not touched.
keeps an unchanged document loaded when another workspace change lands: fails on main (an unchanged document re-minted its URL: expected "vi.fn()" to be called once, but got 2 times), passes here.
keeps an unchanged document mounted while its revision check reloads: guards the loading path.
reloads the document when its URL can no longer be minted: guards the deleted-file path.
loads the new bytes when the document itself changes: guards against never reloading.
At 359bba3 (main merged at d313b2a): vp run check:changed passes format, lint, knip, typecheck, tests and React Compiler. The server-without-fileRevision fallback and the draft transitions are checked by reading the code only; no test or capture drives them.
Evidence
Linux Chromium157; CSS1440×900,DPR2,font16px/100%,dark; Files maximized,explorer256px,preview1184px. R24:CSS900×900,light/dark,preview644px/900px. Synthetic fixtures,local isolated dev servers,free Replay invalidations; T3CODE_DEV_SEED=0. Before d313b2aff3; after 359bba3d25.
25/26 matrix rows have recordings; partial/unverified claims below prevent full-matrix sign-off. Logs sample every250ms. Log-clock times below are seconds after instrumentation; original video clocks differ. DiffT means channel delta>16, without normalization.
Word section20 → two unchanged-byte Replay turns/checkpoints. Video before0s→32.8s resets to section01; after0–36.2s stays20. Log before0.25→22.25s: identity1→6,scrollTop20368→0,checkpoints1→3; after0.26→30.75s: identity1→1,20368→20368,checkpoints1→3 (completions10.59/17.50s).
records400 rows101–150,scroll270/150 → unchanged-byte Replay/checkpoint. Before resets to categories by video~10s (remaining movie is a settled hold); after0–20.6s retains records. Log before0.25→229.25s: identity1→null,scroll270/150→null (one-row table has no sampled scroller),checkpoints6→7; after0.25→20.75s: identity1→1,270/150→270/150,checkpoints9→10. Original R04-before-log.json corroborates identity1→5 and270/150→0/0. Diff0 remains qualified by one unrelated chrome pixel.
Partial: theme retains Word20; resize visibly changes20→15; no font theme transition/splitter drag.
What else changed (every visible difference in the paired zero-threshold comparisons):
R02: section/page numbers01↔20 in heading and paragraphs; vertical content offset and preceding-page white strip. Header/explorer pixels match;165,135 changed pixels.
R04: table selector/categories↔records,page range/navigation state,1row/2columns↔400rows/16columns,headers/widths/cell text/borders/scroll positions/scrollbars,clipped edge cells,and populated↔empty viewport area. Original pair also changes Search caret/focus versus selector outline: not comparable. Recapture removes these rings but has one unrelated chrome pixel(2779,149),RGB31→30; Diff0 is still not a perfectly controlled comparison,2,004,614 changed pixels. Nothing was erased; DiffT suppresses that1-level pixel.
Unverified: R19; exact harness portions of R16/R20/R21; initial null boundaryR01; R06a navigation; remote/waiting/scroll retentionR16; full environment/thread/draft identityR22; CSV/controlsR23; resize reading-position retention and font theme transitionR24. R04 behavior is shown, but its strict zero-threshold comparison remains qualified. Scroll-boundary clipping, ellipsized paths, transient spinner/blank/stale frames and rejected originals are enumerated in capture-review.md. vp test run apps/web/src/components/files/FilePreviewPanel.browser.test.tsx:6/6 pass. The four revision tests cover unchanged/Loading/Failure/changed bytes; two cover Markdown tasks. These tests do not drive R19 legacy fallback or exact R16 waiting/R20–R21 draft transitions.
Review round 1 at 359bba3, two independent reviewers: no code defects found. One verdict MERGE; the other FIX_FIRST only for the then-missing recordings, now attached above.
Proof audit pass 2: retention, reload-on-edit, Refresh, error/recovery and first-open behaviour confirmed in the recordings, with every diff image recomputed. Open capture-quality notes: one rebuilt R02 frame differs from the delivered one inside the explorer-toggle icon (max 7/255); the R04 Diff0 retains one 1-level chrome pixel; several scrolled document stills clip text at the viewport edges.
Not checked: desktop (Electron) and mobile clients, a remote reconnect, a server without fileRevision.
…kspace changes
Unchanged workspace documents re-mint their URL and remount when the
thread's workspace mutation id moves; a real file revision change must
still load the new bytes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Word, PowerPoint and binary previews in the Files panel remounted whenever
the thread's workspace mutation id moved, re-fetching the file and losing
the scroll position even when the file itself was unchanged.
The document branch now reads the server's file revision through
useAssetUrlState, like the video, audio, PDF and large-text previews, and
remounts only when that revision (or an explicit refresh) changes. Drafts
and older servers without a revision keep following the mutation id.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The preview kept its revision only while the asset URL was a success, so a
reconnect (which drops the prepared connection and reports Loading) unmounted
and reloaded the open document. Keep the last resolved revision instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntent
Keep the last file revision only while the asset URL is loading (a
reconnect). A failed mint now remounts the preview, so a file the agent
deleted or moved shows as unavailable, as it did before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR approvable — Document previews now use file revisions to avoid unnecessary reloads after unrelated agent commands, while retaining manual refresh and draft reload behavior. The change is limited to preview lifecycle and preserves existing asset access controls.
No code changes detected at 359bba3. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
Document and binary-file previews now use asset revisions to determine when the preview remounts. Draft documents continue to use workspace mutation IDs. Browser tests cover preview retention, URL minting failures, and changed revisions.
WorkspaceDocumentPreview selects an asset resource and keys the attachment preview by revision and refresh counter. It retains the last resolved revision while loading and uses a failure-specific key after URL errors. Tests cover unchanged revisions, failed URL minting, and changed revisions.
The document-preview change is ready to merge after normal checks; no unresolved behavior has been established that requires a fix.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(web): open documents no longer reload after every agent command" follows conventional commit form and names the main change: open document previews stop reloading after unrelated agent …
Linked Issues check
Issue #32669 requires that an open Word or PowerPoint preview keep its position when commands change no file, and that real file changes load. The diff in apps/web/src/components/files/FilePreviewPane…
Out of Scope Changes check
The whole-PR diff against the merge base changes the document branch of FilePreviewPanel.tsx and adds WorkspaceDocumentPreview, plus the browser test file named in the PR. The HTML, image and PDF bran…
Description check
The description covers the problem and reproduction, explains the change and scope, links the triaged issue, and provides focused test results and detailed before/after UI evidence. It also identifies…
Full details: Title check
Explanation
The title "fix(web): open documents no longer reload after every agent command" follows conventional commit form and names the main change: open document previews stop reloading after unrelated agent commands. The diff changes the document branch of FilePreviewPanel to key the preview on the server-reported fileRevision, which matches the title. The title is specific and short (10 words, 67 characters).
Full details: Linked Issues check
Explanation
Issue #32669 requires that an open Word or PowerPoint preview keep its position when commands change no file, and that real file changes load. The diff in apps/web/src/components/files/FilePreviewPanel.tsx replaces the document-branch key, which used workspaceMutationId, with WorkspaceDocumentPreview. For non-draft media-file resources, the new component calls useAssetUrlState and keys AttachmentFilePreview on the returned fileRevision. An unrelated workspace change therefore keeps the same key and the preview stays mounted. A changed fileRevision produces a new key, so new bytes load. The refreshRevision counter still remounts the preview on an explicit refresh. The shown state keeps the last revision during Loading, which covers a reconnect. A Failure produces a failure-specific key, so a deleted file shows its error. A Success without fileRevision falls back to workspaceMutationId, which keeps the previous behavior for servers that do not report a revision. The approach matches the existing WorkspaceVideoPreview pattern that the issue cites. The author reports browser tests for each path, including a test that fails on main and passes at the reviewed head. I did not run those tests. I did not inspect useAssetUrlState internals, so its re-mint behavior rests on the existing video-preview precedent and the reported tests.
Full details: Out of Scope Changes check
Explanation
The whole-PR diff against the merge base changes the document branch of FilePreviewPanel.tsx and adds WorkspaceDocumentPreview, plus the browser test file named in the PR. The HTML, image and PDF branches are not changed in the diff. The change serves the requested behavior in #32669 directly. Office, binary and document files all use the document branch, so their handling is an intended part of the fix and not an unrelated change. One edge case needs a note and is not a scope failure. A draft non-document binary uses a media-file resource with revision-based keying. The PR text says drafts keep following workspaceMutationId. That holds only when the server reports no fileRevision for that draft resource. I did not verify server behavior for drafts.
Full details: Description check
Explanation
The description covers the problem and reproduction, explains the change and scope, links the triaged issue, and provides focused test results and detailed before/after UI evidence. It also identifies unverified cases and limitations.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfixFix PR opened by an issue lead; enters the PR looppr:gate-failedA land gate failedsize:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
juliusmarminge
added
bugfix
Problem
An open Word, PowerPoint or other document/binary preview in the Files panel reloads and jumps back to its first page after every agent command and checkpoint, even when that file did not change. The document branch of
FilePreviewPanelkeyedAttachmentFilePreviewon the thread-wideworkspaceMutationId, which moves after every completed command, file change and checkpoint.Reproduced on main @ 25bf84a in the web app (fresh database, synthetic files): a 21-page
report.docxscrolled to 2500px was torn down and reloaded at page 1 three times while the agent ransleep 5; echo oneandsleep 5; echo two(two commands plus the checkpoint), with the file untouched. A 400-rowdata.sqlitepreview did the same on a singlegit statusturn (scroll 966 → 0, twice).Change
The document branch now goes through a small
WorkspaceDocumentPreviewthat reads the server'sfileRevisionfor themedia-fileasset withuseAssetUrlState, the same way the video, audio, PDF and large-text previews already do, and remountsAttachmentFilePreviewonly when that revision (or the explicit refresh) changes.Loading), the last revision is kept; the first open shows the loading state until the revision arrives, so the preview mounts once.fileRevisionkeep followingworkspaceMutationIdas before. In a draft, recognized documents (served asdraft-workspace-file) also keep followingworkspaceMutationId; draft unknown binaries aremedia-fileassets and follow their file revision like any other.Scope and approval
Fixes #32669
Triaged bug report; one-branch fix in
apps/web/src/components/files/FilePreviewPanel.tsxplus its browser test. HTML, image and PDF previews are not touched.Verification
Focused tests,
apps/web/src/components/files/FilePreviewPanel.browser.test.tsx(workspace document previews):keeps an unchanged document loaded when another workspace change lands: fails on main (an unchanged document re-minted its URL: expected "vi.fn()" to be called once, but got 2 times), passes here.keeps an unchanged document mounted while its revision check reloads: guards the loading path.reloads the document when its URL can no longer be minted: guards the deleted-file path.loads the new bytes when the document itself changes: guards against never reloading.At 359bba3 (main merged at d313b2a):
vp run check:changedpasses format, lint, knip, typecheck, tests and React Compiler. The server-without-fileRevisionfallback and the draft transitions are checked by reading the code only; no test or capture drives them.Evidence
Linux Chromium157; CSS1440×900,DPR2,font16px/100%,dark; Files maximized,explorer256px,preview1184px. R24:CSS900×900,light/dark,preview644px/900px. Synthetic fixtures,local isolated dev servers,free Replay invalidations;
T3CODE_DEV_SEED=0. Before d313b2aff3; after 359bba3d25.25/26 matrix rows have recordings; partial/unverified claims below prevent full-matrix sign-off. Logs sample every250ms. Log-clock times below are seconds after instrumentation; original video clocks differ. DiffT means channel delta>16, without normalization.
d313b2aff3
359bba3d25
R02-before.mp4
R02-before-log.json
R02-after.mp4
R02-after-log.json
d313b2aff3
359bba3d25
R03-before.mp4
R03-before-log.json
R03-after.mp4
R03-after-log.json
d313b2aff3
359bba3d25
R04-recapture-before.mp4
R04-recapture-before-log.json
R04-recapture-after.mp4
R04-recapture-after-log.json
What else changed (every visible difference in the paired zero-threshold comparisons):
Unverified: R19; exact harness portions of R16/R20/R21; initial null boundaryR01; R06a navigation; remote/waiting/scroll retentionR16; full environment/thread/draft identityR22; CSV/controlsR23; resize reading-position retention and font theme transitionR24. R04 behavior is shown, but its strict zero-threshold comparison remains qualified. Scroll-boundary clipping, ellipsized paths, transient spinner/blank/stale frames and rejected originals are enumerated in capture-review.md.
vp test run apps/web/src/components/files/FilePreviewPanel.browser.test.tsx:6/6 pass. The four revision tests cover unchanged/Loading/Failure/changed bytes; two cover Markdown tasks. These tests do not drive R19 legacy fallback or exact R16 waiting/R20–R21 draft transitions.Drivers: instrument.js · preview-driver.js · export-log.js · capture-helpers.js · compare.py.
Seeds: seed.py · extra-seed.py · mutate-fixture.py · identity-seed.py · long-odp.py · long-path.py · notebook-html.py · widen-sqlite.py · widen-xlsx.py.
Method/fixtures: capture-protocol.md · catalog.json · synthetic-fixtures.zip. All recording logs/stills and verbatim ghdrop outputs: artifact-index.md.
Both continuation servers stopped,own tab closed,before worktree removed,synthetic SQLite restored; after worktree clean. AI-assisted; verified with the tests and tools listed above.
Verification log
fileRevision.AI-assisted; verified with the tests and tools listed above.
🤖 Generated with Claude Code