[juliusmarminge]

Problem

In the desktop app, right-clicking an email address in a chat message (an autolinked restaurant@example.com, or a [label](mailto:…) link) opens the native menu with only Select All enabled. Cut, Copy and Paste are greyed out, and nothing copies the address. The chat's own link menu only handles http:/https: links, so mailto: falls through to the native menu, and that menu adds Copy Link only for web and editor URLs.

Change

The desktop native context menu (apps/desktop/src/window/DesktopWindow.ts) now adds a Copy Email Address item when the right-clicked link is a mailto: URL with an address. The item copies the bare, percent-decoded address, without mailto:, ?subject=… or a fragment, as Chrome's own item does. A mailto: with no address (mailto:?subject=…) gets no item. What the app opens externally is unchanged: parseSafeExternalUrl and openExternal are not touched. The same menu serves the integrated browser, so a mailto: link on a page there gains the item too.

Scope and approval

Fixes #33240

Verification

• vp run check:changed on the head 8de4dad6eb: format, lint, knip, typecheck (2 packages) and DesktopWindow.test.ts (28 tests) pass. The new test, offers to copy the bare address when right-clicking a mailto link, fires the real context-menu handler with mailto:restaurant%40example.com?subject=Hi, clicks Copy Email Address, and expects exactly restaurant@example.com to be copied. On main it fails with no "Copy Email Address" item in ["cut","copy","paste","selectAll"].
• Two independent review rounds; the second round passed with no findings.

Evidence

Real Linux desktop app, each side built from its own checkout on a fresh database, same synthetic data: before 4c361199f4 (main), after 89764a9450; the head 8de4dad6eb only merges later main commits, none of which touch apps/desktop/src/window. Electron 44.10.1 under Xvfb 1920×1080, DPR 1, 1440×900 window, dark app theme. The menu is native and not themed by the app, so light theme and narrow widths are not separate rows. Crops below; full-display stills and both diff images per row are in the evidence index and its addendum (matrix).

Row	Before 4c361199f4	After 89764a9450	Diff0 (exact, amplified)	Clipboard after clicking the item
R01 chat, autolinked restaurant@example.com				restaurant@example.com (22 bytes)
R02 chat, [Reservations](mailto:owner%40example.com?subject=Booking#details)				owner@example.com (17 bytes)
R03 integrated browser, mailto:guest@example.com				guest@example.com (17 bytes)
R06 integrated browser, image inside mailto:image@example.com				image@example.com (17 bytes); Copy Image kept
R09 integrated browser, editable mailto:speller@example.com labelled recieve (real spellchecker)				speller@example.com (19 bytes); suggestions kept above
R15 integrated browser, mailto:?subject=Booking (no address)				no item; 0 changed pixels
R17 integrated browser, https://example.com/ (control)				Copy Link unchanged; 0 changed pixels
R18 chat, [Example](https://example.com) (control)				chat link menu unchanged; 0 changed pixels

Before every click the clipboard held SENTINEL; before the change it still did after the menu closed. Clipboard reads are xclip -o -selection clipboard, no trailing newline.

R01 recording, timestamps read from the encoded video: right-click the address, menu fully drawn 3.5–5.5 s, Escape (before) / click Copy Email Address (after) by 8.0 s, click the composer at 9.0 s, Ctrl+V by 11.5 s. Before pastes SENTINEL; after pastes restaurant@example.com. Frames at each step: before, after.

What else changed: in R01–R03, R06 and R09 the menu grows by the new item and a separator and the items below it move down 46 px; at zero threshold every changed pixel lies inside the menu. R15, R17 and R18 have zero changed pixels. The recordings briefly show the native menu's opening paint and the message's normal hover toolbar between narrated steps.

Seed and driver scripts (synthetic data, not committed): reproduce.md, seed.py, capture-row.py, guest.html, replay transcript.

Not run: the macOS and Windows native menus, and a native Wayland session. The change has no platform-specific code; it adds one item to the shared Electron menu template, which renders on every platform.

AI-assisted; verified with the tests and tools listed above.

[macroscopeapp]

Approvability

Verdict: Approved at d83193b

Macroscope's review found this PR approvable — Adds “Copy Email Address” when right-clicking a mailto link, copying the address without its query parameters. The action only writes to the local clipboard when selected and leaves existing menu actions unchanged.

No code changes detected at 8de4dad. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The desktop context menu now offers “Copy Email Address” for valid mailto: links. Selecting the item copies the decoded address. A test verifies the menu item and copied text.

Changes: Email address copying

Layer / File(s)	Summary
Parse mailto links and copy addresses apps/desktop/src/window/DesktopWindow.ts, apps/desktop/src/window/DesktopWindow.test.ts	The context menu parses mailto: links and adds a “Copy Email Address” action that copies the parsed address. The test mock accepts a copy callback, and a test checks that an encoded address is copied in decoded form.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: maria-rcks, t3dotgg

Merge Risk: Minimal · up to 89764

The new menu action is reported to copy the decoded email address, and no merge-blocking issue is identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly summarizes the main change: adding a Copy Email Address action for mailto links in the desktop context menu.
Linked Issues check		[#33240] The issue requires a one-right-click action that copies the bare address from a mailto: link. The change adds Copy Email Address to the desktop native context menu and copies the decoded URL …
Out of Scope Changes check		The reported production change in apps/desktop/src/window/DesktopWindow.ts implements the requested mailto: copy action. The DesktopWindow.test.ts changes support the copy assertion and test the new m…
Description check		The description covers the problem, change, scope, and focused verification. It includes before-and-after UI evidence and states what was not tested. It says the work was AI-assisted but does not iden…

Full details: Linked Issues check

Explanation

[#33240] The issue requires a one-right-click action that copies the bare address from a mailto: link. The change adds Copy Email Address to the desktop native context menu and copies the decoded URL pathname without the mailto: prefix, query, or fragment. The test summary reports coverage for a percent-encoded address and a query string. The PR also reports Linux verification for autolinked and labelled links. The issue's separate click behavior in #31133 is not a coding requirement for this issue.

Full details: Out of Scope Changes check

Explanation

The reported production change in apps/desktop/src/window/DesktopWindow.ts implements the requested mailto: copy action. The DesktopWindow.test.ts changes support the copy assertion and test the new menu item. Applying the item to other windows that share the native menu is the same mailto: copy behavior. The PR reports that external URL parsing and opening remain unchanged. No unrelated changes are identified in the supplied whole-PR summary.

Full details: Description check

Explanation

The description covers the problem, change, scope, and focused verification. It includes before-and-after UI evidence and states what was not tested. It says the work was AI-assisted but does not identify the model and harness requested by the template.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-33240
• File: .coderabbit.config.ts
• Commit: 89764a9
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: af4faf02-62e1-4e89-9b23-60a40946044a

Commits

Reviewing files that changed from the base of the PR and between d83193b and 89764a9.

Files selected for processing: 2

• apps/desktop/src/window/DesktopWindow.test.ts
• apps/desktop/src/window/DesktopWindow.ts

Limit details: You’ve used all 10 included reviews currently available.