[codex] Structure browser target resolution errors

[juliusmarminge]

Summary

• replace generic browser target failures with schema-tagged errors carrying environment and host context
• preserve the native URL parsing cause alongside the invalid environment base URL
• add focused coverage for disconnected, public-host, and malformed connection cases

Verification

• vp test apps/web/src/browser/browserTargetResolver.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized resolver and shared URL-redaction helpers; behavior is unchanged aside from error shape and safer diagnostics, with no auth or data-path changes in this diff.

Overview
resolveBrowserNavigationTarget now throws three Effect Schema.TaggedErrorClass types instead of generic Errors: disconnected environment, invalid environment HTTP base URL (with native parse cause), and non–private-network host (with environmentId and hostname).

Invalid-base-URL failures use new getUrlDiagnostics (@t3tools/shared/urlDiagnostics) so errors expose only input length and optional protocol/hostname—tests assert messages and shapes never leak credentials or full URLs.

Shared redactDpopRequestTarget strips userinfo, query, and fragment from URLs for safe logging (invalid input → "<invalid-url>"), with tests only in this PR.

Breaking for callers: anything that matched generic error strings must handle tagged errors by _tag / type instead.

^{Reviewed by Cursor Bugbot for commit c7db911. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic errors with structured tagged error classes in resolveBrowserNavigationTarget

• Introduces three new tagged error classes in browserTargetResolver.ts: BrowserTargetEnvironmentDisconnectedError, BrowserTargetEnvironmentUrlInvalidError, and BrowserTargetPrivateNetworkRequiredError, each with structured properties and computed messages.
• BrowserTargetEnvironmentUrlInvalidError uses a new getUrlDiagnostics helper (in packages/shared/src/urlDiagnostics.ts) to expose only non-sensitive diagnostics (input length, protocol, hostname) when a URL cannot be parsed.
• Adds redactDpopRequestTarget to packages/shared/src/dpop.ts to produce redacted DPoP request targets without leaking user info, query, or fragment.
• Behavioral Change: callers catching errors from resolveBrowserNavigationTarget will now receive typed tagged errors instead of generic Error instances.

^{Macroscope summarized c7db911.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a01d1ce4-2664-439d-9186-bdab227bbd53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/browser-target-resolution-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured Effect TaggedErrorClass types instead of plain Error objects. The error conditions and messages remain identical; only the structure is enhanced for better typing and diagnostics. Low-risk mechanical change with comprehensive test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate c7db911