Repository navigation
fix(server): Pi Auto defaults fall back to Auto-accept edits - #33331
Closed
StiensWout wants to merge 4 commits into
Closed
StiensWout wants to merge 4 commits into
StiensWout wants to merge 4 commits into
Conversation
A thread whose mode its provider does not offer fell back to Supervised on the server and to the first listed mode on web and mobile. It now runs in the broadest supported mode below the one asked for, through one shared resolveSupportedRuntimeMode in contracts that the server runtime policy, the web and mobile composers and delegated launches all use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…licate tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT 6.1 Sol <codex@openai.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 (Grok) <noreply@x.ai>
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Unsupported permission modes now fall back to the broadest supported mode below them, including Auto-accept edits for Pi threads inheriting Auto. This changes effective defaults and removes previously required edit approvals, requiring human confirmation of the intended permission behavior. You can add or adjust custom eligibility rules. Learn more. |
2 tasks done
Member
|
Thanks, @StiensWout, for fixing the Pi permission fallback and documenting the validation. #30552 by @juliusmarminge already addresses the same step-down across server, web, mobile, and delegation, with a real Pi runtime reproduction. Closing this as a duplicate; please continue the discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pi threads with an Auto default fell back to Supervised and asked on every command. They now fall back to Auto-accept edits through one shared descending capability policy used by web, mobile, server execution, and delegated launches.
Supported selections stay unchanged. An unsupported selection resolves to the broadest supported mode below it, never above it. Explicit unsupported delegation requests still fail, and managed ceilings remain authoritative. Existing Pi and Antigravity threads stored as Auto also use Auto-accept edits; fx threads stored as Full access use Auto. No provider settings or controls were added.
Standard size: a shared policy interface and its consumers change together. Rebased onto upstream main; range-diff confirmed unchanged patches.
Validation
pnpm exec vp run check:changedpasses. Full suites, build, and release smoke remain with CI.Allow bash?and was blocked when declined. Server policy also refused stored Auto above a managed ceiling before fallback.check:changed, all passing.Review dispositions
Local cubic: stale fx permission guidance fixed. Its remaining P3 rank-table duplication is preexisting. The proposed removal of delegation's early capability check would accept explicit unsupported Supervised requests when a provider only advertises broader modes, so the check stays.
The mobile managed-ceiling clamping suggestion was declined: compatibility reports provider capability, while the server rejects an above-ceiling stored mode before fallback. Hiding disabled choices would display a mode the server does not run. All three reviewers accepted this disposition in round 2.
Follow-ups outside this issue: web
ChatComposer.tsx:892checks the compatible mode for its ceiling notice while the server checks the stored mode; the MCP rank tables indelegatedTaskModes.ts:14andMcpInvocationContext.ts:65could reuse contracts comparisons. Pi's defensivemcpInjection.ts:310mapping remains separate, andAntigravityProvider.test.ts:351still has an old fallback title. Mixed-version remote clients were not verified.Council review
Rounds: 2
Built and simplified by Claude Opus 5.5; coordinated and audited by GPT 6.1 Sol; reviewed by Claude Opus 5.5, GPT 6.1 Sol, and Grok 4.7 (Grok); evidence by Grok 4.7 (Grok) and GPT 6.1 Sol, using T3 Code and the Codex, Claude, and Grok harnesses. GPT 6.1 Sol recovered evidence after Grok's Pi discovery harness could not open the picker; discovery still blocked integrated Pi proof.
Closes #30538