[juliusmarminge]

OrchestratorMcpService.runExecutedModel reads providerTurn.model, but only ClaudeAdapterV2 set it, so Codex and Pi runs always showed executedModel: null in task_status and t3_thread_read. Codex: the adapter already worked out the model for each turn (reportedTurnModel: the rerouted model, otherwise the model from the last thread settings update) and only passed it into turnTokenUsage.models. It now computes that value once and also sets it as the completed provider turn's model. Pi: the message_end handler now reads the provider and model strings from each assistant message and keeps the latest as provider/model on the active turn. The settle path's terminal provider_turn.updated sets model from it. No new regex or parser: Pi uses the existing piRecordString field lookup and a template string, which is constant time per message.

Fixes #34280

Reproduction on main

Commit f6433db (origin/main). Started an isolated server: T3CODE_DEV_SEED=0 node src/bin.ts serve --base-dir <scratch home> --port <p> <scratch git repo>, with settings.json enabling the pi provider instance; t3 project add on the scratch repo. Ran t3 thread start --provider pi --model <pi model> --wait --json <proj> "Reply with the single word OK." and the same with --provider codex --model <codex model>; both runs finished completed with reply OK. Read each thread through the t3_thread_read MCP tool (runLimit 1; raw structuredContent dumped by a temporary uncommitted line in the CLI, since t3 thread show --json drops recentRuns). Both returned thread {latestRunId: , activeRunId: null, status: completed} and recentRuns[0] {status: completed, providerInstanceId: pi|codex, model: , executedModel: null}. The persisted orchestration_v2_projection_provider_turns rows for both runs have no model in payload_json. executedModel is computed in OrchestratorMcpService.runExecutedModel from providerTurn.model, which only ClaudeAdapterV2 sets. Wrote two adapter tests that fail on main: Codex root turn with a model/rerouted notification records the model in turnTokenUsage.models but providerTurn.model is undefined; Pi message_end carrying provider/model leaves the completed providerTurn.model undefined.

Evidence

On fresh isolated servers, delegate “Reply with the single word OK.” to real Codex and Pi providers. After completion, read task_status and t3_thread_read(runLimit=1). All four tasks completed with “OK”. Runtime model identifiers are redacted; null values are preserved.

Before	After
f6433dba45	8f4d994bc0
Codex and Pi: executedModel: null in both MCP projections. Persisted provider turns have no model.	Codex and Pi: non-null executedModel in both MCP projections, matching persisted provider-turn models.
Runtime transcript · MCP JSON	Runtime transcript · MCP JSON

Driver scripts and setup instructions

AI-assisted; verified with the tests and tools listed above.

Not shown:

• A Codex model reroute was not forced; the evidence covers successful completed runs through both real providers.

Tests

vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: 152 passed. vp test run packages/provider-pi/src/server/adapter.test.ts: 122 passed. Both repro tests ('records the model ...') confirmed failing with the fix stashed: expected undefined to equal 'gpt-5.6-sol' / 'anthropic/model-b'. vp run check:changed: format, lint, knip, typecheck (9 packages), tests (3 files, 276) all passed.

Not in this change

• Pi live-usage provider_turn.updated events (sent mid-turn) still leave out the model; only the terminal update carries it, and that is what executedModel reads.
• Other adapters (Cursor, Grok, OpenCode, Antigravity, Kiro) were not checked for setting providerTurn.model.

AI-assisted; verified with the tests and tools listed above.

[macroscopeapp]

Approvability

Verdict: Approved at 8f4d994

Macroscope's review found this PR approvable — Codex and Pi terminal turn updates now include the provider-reported model, allowing run-status responses to identify what actually ran. The change is limited to reporting metadata and does not alter model selection or execution defaults.

No code changes detected at 26c67f7. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.5 KiB	21.5 KiB	0 B (0.0%)	24.4 KiB	✅
Codex	Live turn messages	1	1	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	0 B (0.0%)	24.4 KiB	✅
Claude	Live turn messages	1	1	0 (0.0%)	8	✅

Baseline: c8ddb22 · PR result: 26c67f7 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Codex and Pi adapters now set the completed provider turn’s model from execution-reported information. Tests cover a Codex model reroute and a Pi assistant message that reports its provider and model.

Changes: Executed model reporting

Layer / File(s)	Summary
Codex model finalization apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts	Codex finalization uses the resolved model for token-usage completion and adds it to the completed provider turn when available. A replay test checks that a rerouted model appears in both locations.
Pi model reporting packages/provider-pi/src/server/adapter.ts, packages/provider-pi/src/server/adapter.test.ts	Pi records provider/model from assistant messages when both values are present, then includes the recorded value in the completed provider turn. A test checks the reported provider and model.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  participant NativeTurn
  participant CodexAdapter
  participant PiAdapter
  participant ProviderTurn
  NativeTurn->>CodexAdapter: report executed model
  CodexAdapter->>ProviderTurn: set completed turn model
  PiAdapter->>ProviderTurn: include model reported by assistant message

Loading

Possibly related PRs

• pingdotgg/t3code#29001: Changes Codex model-reroute tracking and passes the reported model into completed token usage.

Suggested labels: bugfix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 7c077

Codex and Pi completed runs now report the model that executed them. No merge-blocking risk is evident.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: Codex and Pi runs now report the provider-executed model.
Description check		The description explains the problem, implementation, reproduction, verification results, evidence, and known limitations. It does not use the template headings or explicitly document scope and approv…
Linked Issues check		Issue [#34280] is closed and completed. It provides historical context only. No active directly linked issue remains, so no linked-issue coding requirements apply.
Out of Scope Changes check		The changes update Codex and Pi provider-turn model recording and add focused regression tests. These changes match the current PR intent and the historical behavior described by [#34280]. No unrelate…

Full details: Description check

Explanation

The description explains the problem, implementation, reproduction, verification results, evidence, and known limitations. It does not use the template headings or explicitly document scope and approval, but it is otherwise mostly complete and directly related to the change.

Full details: Out of Scope Changes check

Explanation

The changes update Codex and Pi provider-turn model recording and add focused regression tests. These changes match the current PR intent and the historical behavior described by [#34280]. No unrelated change is shown in the available whole-PR summary.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 2
• Charged: $0.50
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: factory/issue-34280
• File: .coderabbit.config.ts
• Commit: 7c0772d
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 6095560f-344e-4b3d-a07d-595dcca7a797

Commits

Reviewing files that changed from the base of the PR and between 8f4d994 and 7c0772d.

Files selected for processing: 2

• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts
• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts

Limit details: You’ve used all 10 included reviews currently available.

[juliusmarminge]

The automated pipeline stopped on this pull request and will not merge it:

someone else pushed to factory/issue-34280 (head is now 7c0772d); the pipeline does not build on commits it did not review

It stays open for a person to finish or close.