Repository navigation
fix(web): cancelled PR checks show a gray stop sign instead of the failed X - #34734
Merged
Merged
Conversation
…iled X Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Cancelled PR checks now display a muted octagon-X instead of the red failure icon. Labels and aggregate check-status behavior remain unchanged, limiting the impact to presentation. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelled checks in the PR checks popover used the same red `CircleXIcon` as failed checks, so a cancelled bot run (for example CodeRabbit) looked identical to a real failure.
Cancelled now uses a muted gray `OctagonXIcon`, matching GitHub's gray stop sign and the muted tint mobile already uses for cancelled checks. The rollup still counts cancelled as failing, unchanged.
Made by Claude Opus 5.5 in T3 Code (Cursor harness).
Made with Cursor