Skip to content

test(web): inline confirm tests no longer race the 3s disarm timer #35361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 1 commit into from
Nov 12, 2026
+4 −1
Merged

test(web): inline confirm tests no longer race the 3s disarm timer #35361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/web/src/components/pullRequest/useInlineActionConfirm.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render } from "../../../test/render";
import { fakeTimers, render } from "../../../test/render";
import { expect, it, vi } from "vite-plus/test";
import { userEvent } from "vite-plus/test/browser";

Expand All @@ -22,6 +22,8 @@ function pressEscape(): KeyboardEvent {
it("confirms on the second click and disarms on Escape", async () => {
const onConfirm = vi.fn();
await using screen = await render(<MergeButton scopeKey="a" onConfirm={onConfirm} />);
// An armed action disarms after 3s, and a slow runner can take longer between two clicks.
using _timers = fakeTimers();
const button = screen.getByRole("button");

await userEvent.click(button);
Expand Down Expand Up @@ -99,6 +101,7 @@ it.each(["merge", "enable-auto-merge"] as const)(
/>
);
await using screen = await render(control("Checking stack membership…"));
using _timers = fakeTimers();
const button = screen.getByRole("button");
await userEvent.tab();
await expect.element(button).toHaveFocus();
Expand Down
Loading