[MasonNight]

The development SSH launcher reports an incompatible remote Node version and then incorrectly says Node is missing. Only print the missing-executable guidance when discovery actually leaves no node command, preserving the original engine diagnostic and exit status.

Fixes #35583.

Verification:

• Added a regression case that runs the production SSH launch script in a real shell with incompatible and missing Node fixtures. Before the fix, the incompatible case included both messages; afterward it retains only the version diagnostic. Missing Node still reports installation guidance. Both exit 1.
• Ran the generated engine probe outside the test transformer with real Node 26.12.1 and an unsupported range: exit=1; Remote node 26.12.1 does not satisfy required range >=999.0.0.

Validation limits on this Windows host: check:changed passes formatting, lint, and both knip checks. Its test step hits three existing shell-fixture failures (archive download, missing gzip, and POSIX versus Windows server PID); all three also fail on untouched origin/main. The affected SSH package typecheck passes. The dependent server typecheck reports an unavailable FileFinder.scanFilesAsync API in unchanged WorkspaceSearchIndex.ts.

Model: GPT-6.1 Sol. Harness: Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at d6063b5

Macroscope's review found this PR approvable — The SSH launcher stops reporting Node as missing when an executable exists but is incompatible. Validation and launch failure behavior remain unchanged; the change only refines the error output.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 70833b2
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: b19d4056-9b4b-4d78-832c-27db6cada3f8

Commits

Reviewing files that changed from the base of the PR and between 78e54c1 and df62432.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The remote launch script now prints the missing-Node diagnostic only when Node is unavailable. It still exits with status 1 when Node does not meet the required engine range. A live test checks both failure cases.

Changes: Remote Node diagnostics

Layer / File(s)	Summary
Node failure diagnostics and test packages/ssh/src/tunnel.ts, packages/ssh/src/tunnel.test.ts	The launch script prints the missing-Node diagnostic only when Node is unavailable. The test checks that missing Node and an incompatible version produce distinct diagnostics, and that both exit with status 1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge, t3dotgg

Merge Risk: Low · previous review 78e54

This change only affects which error message the SSH launch script prints, and it keeps the exit status. The new test was reported failing in CI, but a source review found no path to that failure. Confirm that CI passes before merging.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: the SSH script now separates an incompatible Node version from a missing Node executable. It uses a conventional commit prefix and fits the summary, objectives, and li…
Description check		The description covers the problem, the change, the linked issue, and detailed verification. It does not follow the template headings (Problem, Change, Scope, Verification). It lacks an explicit Scope…
Linked Issues check		Issue #35583 requires three coding outcomes. (1) An installed Node that fails the engine range must produce only the version diagnostic. In packages/ssh/src/tunnel.ts, the missing-Node printf in REMOT…
Out of Scope Changes check		The whole-PR diff (merge base 91f55d9 to head 78e54c1) touches only packages/ssh/src/tunnel.ts and packages/ssh/src/tunnel.test.ts. The tunnel.ts change is a three-line guard around the existing missi…

Full details: Title check

Explanation

The title names the main change: the SSH script now separates an incompatible Node version from a missing Node executable. It uses a conventional commit prefix and fits the summary, objectives, and linked issue #35583.

Full details: Description check

Explanation

The description covers the problem, the change, the linked issue, and detailed verification. It does not follow the template headings (Problem, Change, Scope, Verification). It lacks an explicit Scope statement that justifies the fix as a bug fix, although it links issue #35583. The verification section is detailed and states what could not be checked. The model and harness are named at the end.

Full details: Linked Issues check

Explanation

Issue #35583 requires three coding outcomes. (1) An installed Node that fails the engine range must produce only the version diagnostic. In packages/ssh/src/tunnel.ts, the missing-Node printf in REMOTE_LAUNCH_SCRIPT is now wrapped in if ! command -v node >/dev/null 2>&1; then. When node exists but ensure_remote_node_path fails, the missing-Node message is skipped and the engine diagnostic from ensure_remote_node_path remains. (2) Missing Node must keep its guidance. When command -v node fails, the message is still printed. (3) Exit status is unchanged. exit 1 still runs after the branch in both cases. The new test in packages/ssh/src/tunnel.test.ts runs launchOrReuseRemoteServer with an incompatible-Node fixture and a missing-Node fixture. It asserts exitCode 1 and asserts each message appears only in its matching case. The requirement to keep successful launch with a compatible Node on PATH and to reject without automatic selection is not changed by this diff. It relies on existing behavior, which this review did not re-run. No non-coding requirements were found. The shell-fixture failures reported on Windows were not re-run in this review.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff (merge base 91f55d9 to head 78e54c1) touches only packages/ssh/src/tunnel.ts and packages/ssh/src/tunnel.test.ts. The tunnel.ts change is a three-line guard around the existing missing-Node printf. The test.ts change adds one regression case for the same behavior. Both changes connect directly to #35583. No unrelated changes were found.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 7eca0ed
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: e277f00f-3300-41e4-b4fe-dee701c501d0

Commits

Reviewing files that changed from the base of the PR and between d6063b5 and 78e54c1.

Files selected for processing: 1

• packages/ssh/src/tunnel.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

[coderabbitai]

Additional comments: 1

packages/ssh/src/tunnel.test.ts-182-183: 1

182-183: Major · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Repair the shell fixture that fails in CI.

The supplied Test check reports exit code 127 at Line 199, not 1. This added test therefore fails before it checks either diagnostic. Inspect the captured result.failure.stderr to identify the failing shell command, then correct the fixture or its environment. Keep the expected exit code 1.

Source: Linters/SAST tools

Review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 7eca0ed
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3e5d186f-4586-409c-bc5b-82e698664d88

Commits

Reviewing files that changed from the base of the PR and between 7eca0ed and d6063b5.

Files selected for processing: 2

• packages/ssh/src/tunnel.test.ts
• packages/ssh/src/tunnel.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[juliusmarminge]

Evidence

Environment: real Linux x86_64 Electron desktop under headless-desktop; light theme; 1100×780 viewport. Separate fresh T3 homes with T3CODE_DEV_SEED=0 and no imported data. Real OpenSSH and Node binaries; no mocked diagnostics.

Steps on both commits: Settings > Environments > Add environment > SSH; enter diagnostic-proof, username user, port 22367; Add environment. Repeat with Node 18.20.8, no discoverable Node, and Node 24.10.0.

Before	After
70833b2f55	df62432cbb
Before recording	After recording
Missing-Node recording before	Missing-Node recording after
Compatible-Node recording before	Compatible-Node recording after

Base displays both diagnostics; head displays only the incompatible-version diagnostic. Both reject Node 18.20.8 with exit status 1. Missing Node retains installation guidance on both commits; Node 24.10.0 connects successfully on both.

Driver and fixture scripts · Reproduction instructions · Base runtime transcript · Head runtime transcript

AI-assisted; verified with the tests and tools listed above.