You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): read_pull_request_guide reads no-checkout hosts through the caller's project - #35913
read_pull_request_guide threw PullRequestProjectNotFoundError whenever projectForPullRequest found no project whose repository identity matched the PR, before calling PullRequestReviewGuideService.get. PullRequestService's readsPublicHostWithoutCheckout fallback (GitHub, Bitbucket, Forgejo), which the app's PR panel already uses, was therefore never reached. locateAll now also returns the caller's project, and read_pull_request_guide falls back to it when no checkout matches, letting PullRequestService decide whether the host can be read without a checkout. When it cannot (PullRequestUnavailableError with reason provider-unsupported, and no matching project), the handler still returns PullRequestProjectNotFoundError with the existing message, so hosts that need a checkout behave as before. link_pull_request was not affected and is unchanged. No new regex or parser. I did not reproduce the bug myself and relied on the repro branch's failing test.
On origin/main 7fb6098: started T3CODE_DEV_SEED=0 vp run dev (fresh database), added one project via node src/bin.ts project add whose checkout's origin is github.com/pingdotgg/t3code, then from a scratch driver issued a short-lived MCP client session (as t3 thread does) and called read_pull_request_guide over /mcp. With url #35755 (the project's own repo) it succeeded and returned currentHeadSha. With url Effect-TS/effect#5000 (public, no project) it returned isError with: "No project in this environment is a checkout of effect-ts/effect, so its pull requests cannot be read here. Add one with t3_project_create." GitHub sets readsPublicHostWithoutCheckout like Bitbucket, so this is the same code path the reporter hit; no Bitbucket account is available on the VM. link_pull_request does not go through projectForPullRequest and links a URL from any repository (an existing handler test covers that), so only reading the guide fails. Driver: https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/e7dfd36e33a6f11d/driver.ts Transcript: https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/b338a5798c396439/run-main.txt
Evidence
Call read_pull_request_guide from an actual replay-agent thread on fresh real servers. Each environment contains only a T3 Code checkout. Read the own-repository control, then Effect PR #5000, without adding an Effect checkout.
Permanent blocker: direct Bitbucket verification requires a Bitbucket account unavailable on this VM. The supplied GitHub reproduction demonstrates the same no-checkout path.
Forgejo-specific reads and unsupported-host error mapping were not exercised; this proof covers the supplied GitHub reproduction.
Tests
vp test run src/mcp/toolkits/pullRequests/handlers.test.ts (apps/server): 20/20 pass, including the repro test from factory/repro-35891. vp run check:changed: format, lint, knip, graphql, typecheck (3 packages), tests (2 files, 22 tests) all pass.
Not in this change
write_pull_request_guides still refuses a PR with no matching project; generating a guide needs a checkout to fetch the head, so that refusal is intended and was left alone.
Who did the work
Written by Claude Opus 5.5, in Claude Code
Reviewed by GPT-6.1 Sol, in Codex, and by Claude Opus 5.5, each on its own
Proof captured by GPT-6.1 Sol and checked by Claude Opus 5.5
…ough the caller's project
Fails on main: the handler refuses with PullRequestProjectNotFoundError before
PullRequestService's readsPublicHostWithoutCheckout fallback can read it (#35891).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the caller's project
The tool refused with PullRequestProjectNotFoundError whenever no project
was a checkout of the pull request's exact repository, so PullRequestService
never reached its readsPublicHostWithoutCheckout path (GitHub, Bitbucket,
Forgejo). Fall back to the calling thread's project and let the service
decide; a host it cannot read that way still reports the missing project.
Fixes#35891
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The pull request guide handler now uses the caller’s project when no project matches the pull request repository. The handler maps an unsupported provider error in this fallback path to PullRequestProjectNotFoundError. A test covers reading a Bitbucket pull request without a repository checkout.
Changes: Bitbucket pull request guide fallback
Layer / File(s)
Summary
Pass caller project through guide lookup apps/server/src/mcp/toolkits/pullRequests/handlers.ts, apps/server/src/mcp/toolkits/pullRequests/handlers.test.ts
locateAll carries the caller’s project into its results. read_pull_request_guide uses that project when no project matches the target. When the fallback project’s provider is unsupported, the handler returns PullRequestProjectNotFoundError. The test checks the returned pull request identity, null guide, and head SHA.
Reading a pull request guide for a repository with no checkout now falls back to the caller's project, which fixes the reported Bitbucket read case. No merge-blocking risk was found. Linking pull requests without a checkout is not covered by this change.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the fix and its scope: read_pull_request_guide reading no-checkout hosts through the caller's project. The changeset adds a caller-project fallback in read_pull_request_guide and a tes…
Linked Issues check
[#35891] Read path: the reviewed head now falls back to the caller's project in read_pull_request_guide (handlers.ts). locateAll returns callerProject per entry, and the guide read runs with `entr…
Out of Scope Changes check
All changes are in apps/server/src/mcp/toolkits/pullRequests/handlers.ts and its handlers.test.ts. The locateAll change adds callerProject to each entry and the read handler uses it only as a fall…
Description check
The description covers the required template areas in substance. Problem: read_pull_request_guide threw PullRequestProjectNotFoundError before PullRequestReviewGuideService.get ran, so the public-host…
Full details: Title check
Explanation
The title names the fix and its scope: read_pull_request_guide reading no-checkout hosts through the caller's project. The changeset adds a caller-project fallback in read_pull_request_guide and a test for it, so the title matches the main change. It is long at 89 characters, but it is specific and conventional.
Full details: Linked Issues check
Explanation
[#35891] Read path: the reviewed head now falls back to the caller's project in read_pull_request_guide (handlers.ts). locateAll returns callerProject per entry, and the guide read runs with entry?.project ?? entry?.callerProject. A PR with no matching project therefore reaches PullRequestReviewGuideService.get and the readsPublicHostWithoutCheckout logic in PullRequestService. The added handler test covers reading a Bitbucket PR for a repository with no checkout and asserts host, repository, number, null guide, and current head SHA. Link path: link_pull_request resolves its target with the caller's project (projectOf(thread)) and does not call projectForPullRequest, so the link behavior the issue requests is already present at the base and is unchanged. Not verified: the PullRequestService fallback itself was not re-read in this assessment; the read fix depends on it. Non-coding items (manual before/after evidence capture) are excluded. The PR objectives text says linking is not included, but the code at head shows linking does not hit the reported failure, so no linking work is missing.
Full details: Out of Scope Changes check
Explanation
All changes are in apps/server/src/mcp/toolkits/pullRequests/handlers.ts and its handlers.test.ts. The locateAll change adds callerProject to each entry and the read handler uses it only as a fallback. The error mapping converts only PullRequestUnavailableError with reason provider-unsupported, and only when no matching project exists, into the existing PullRequestProjectNotFoundError. Other errors keep PullRequestGuideFailedError. The test supports the read fix. No unrelated changes were identified in the diff reviewed. The diff was not read in full beyond the handlers.ts hunks and the test summary, so this conclusion is limited to those sources.
Full details: Description check
Explanation
The description covers the required template areas in substance. Problem: read_pull_request_guide threw PullRequestProjectNotFoundError before PullRequestReviewGuideService.get ran, so the public-host no-checkout fallback in PullRequestService was never reached. Change: locateAll also returns the caller's project, and the handler falls back to it. The provider-unsupported case still returns the existing error, and link_pull_request is unchanged. Scope: it links a bug (issue #35891) and gives a reason for the fix. Verification: it reports a reproduction on main with before/after transcripts for a GitHub public PR, 20/20 handler tests passing, and check:changed passing. It also states what was not checked (direct Bitbucket verification and Forgejo reads). The 'Who did the work' section names the model and harness, as the template asks. Two items need attention: the Evidence table's 'after' column cites a commit hash and transcript links, which the reviewer should confirm are reachable. The 'Before' and 'After' transcript links point to external file-drop hosts that a reviewer may not be able to verify. The description also says 'The before-and-after evidence section is still marked as being captured' in the PR objectives, which conflicts with the populated table. Overall the description is mostly complete and specific.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
Macroscope's review found this PR approvable — Guide reads can now use the caller's project for hosts that already support reading without a checkout. Existing provider restrictions remain in place, and guide generation is unchanged.
You can add or adjust custom eligibility rules. Learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
read_pull_request_guide threw PullRequestProjectNotFoundError whenever projectForPullRequest found no project whose repository identity matched the PR, before calling PullRequestReviewGuideService.get. PullRequestService's readsPublicHostWithoutCheckout fallback (GitHub, Bitbucket, Forgejo), which the app's PR panel already uses, was therefore never reached. locateAll now also returns the caller's project, and read_pull_request_guide falls back to it when no checkout matches, letting PullRequestService decide whether the host can be read without a checkout. When it cannot (PullRequestUnavailableError with reason provider-unsupported, and no matching project), the handler still returns PullRequestProjectNotFoundError with the existing message, so hosts that need a checkout behave as before. link_pull_request was not affected and is unchanged. No new regex or parser. I did not reproduce the bug myself and relied on the repro branch's failing test.
Fixes #35891
Reproduction on main
On origin/main 7fb6098: started
T3CODE_DEV_SEED=0 vp run dev(fresh database), added one project vianode src/bin.ts project addwhose checkout's origin is github.com/pingdotgg/t3code, then from a scratch driver issued a short-lived MCP client session (ast3 threaddoes) and called read_pull_request_guide over /mcp. With url #35755 (the project's own repo) it succeeded and returned currentHeadSha. With url Effect-TS/effect#5000 (public, no project) it returned isError with: "No project in this environment is a checkout of effect-ts/effect, so its pull requests cannot be read here. Add one with t3_project_create." GitHub sets readsPublicHostWithoutCheckout like Bitbucket, so this is the same code path the reporter hit; no Bitbucket account is available on the VM. link_pull_request does not go through projectForPullRequest and links a URL from any repository (an existing handler test covers that), so only reading the guide fails. Driver: https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/e7dfd36e33a6f11d/driver.ts Transcript: https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/b338a5798c396439/run-main.txtEvidence
Call
read_pull_request_guidefrom an actual replay-agent thread on fresh real servers. Each environment contains only a T3 Code checkout. Read the own-repository control, then Effect PR #5000, without adding an Effect checkout.isError:true, “No project in this environment is a checkout of effect-ts/effect…”isError:false,currentHeadSha:46f78576843b3ee8d706337d8c4fe23ccf8db516The own-repository control succeeds on both commits. MCP driver, transparent replay-agent relay, reproduction instructions.
Not shown:
Tests
vp test run src/mcp/toolkits/pullRequests/handlers.test.ts (apps/server): 20/20 pass, including the repro test from factory/repro-35891. vp run check:changed: format, lint, knip, graphql, typecheck (3 packages), tests (2 files, 22 tests) all pass.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.