Skip to content

fix(mobile): Android terminal resizes the engine when only the cell size changes #36023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Nov 13, 2026
+10 −10
Merged

fix(mobile): Android terminal resizes the engine when only the cell size changes #36023

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6404004
fix(mobile): Android terminal resizes the engine when only the cell s…
juliusmarminge Nov 13, 2026
add6eac
fix(mobile): keep the Android terminal grid check under detekt's comp…
juliusmarminge Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...obile/modules/t3-terminal/android/src/main/java/expo/modules/t3terminal/T3TerminalView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class T3TerminalView(context: Context, appContext: AppContext) : ExpoView(contex
private var streamedOutput: TerminalOutputBuffer? = null
private var cols = 0
private var rows = 0
private var cellSize = 0 to 0
private var measuredCols = 0
private var measuredRows = 0
private var clearingInput = false
Expand Down Expand Up @@ -356,25 +357,24 @@ class T3TerminalView(context: Context, appContext: AppContext) : ExpoView(contex
applyGrid()
}

@Suppress("ComplexCondition")
private fun applyGrid() {
if (measuredCols <= 0 || measuredRows <= 0 || isCleanedUp) return
val shared = sharedGrid.takeIf { it.size == 2 && it[0] > 0 && it[1] > 0 }
val nextCols = shared?.get(0)?.coerceAtMost(measuredCols) ?: measuredCols
val nextRows = shared?.get(1)?.coerceAtMost(measuredRows) ?: measuredRows
if (nextCols == cols && nextRows == rows && terminalHandle != 0L) return
val nextCellSize = terminalCanvas.cellWidthPx.toInt() to terminalCanvas.cellHeightPx.toInt()
if (nextCols == cols && nextRows == rows && nextCellSize == cellSize && terminalHandle != 0L) {
return
}
cols = nextCols
rows = nextRows
cellSize = nextCellSize
val response = if (terminalHandle == 0L) {
createTerminal()
ByteArray(0)
} else {
GhosttyBridge.nativeResize(
terminalHandle,
cols,
rows,
terminalCanvas.cellWidthPx.toInt(),
terminalCanvas.cellHeightPx.toInt(),
)
GhosttyBridge.nativeResize(terminalHandle, cols, rows, cellSize.first, cellSize.second)
}
emitResponse(response)
if (!hasPendingBuffer) feedPendingBuffer()
Expand All @@ -387,8 +387,8 @@ class T3TerminalView(context: Context, appContext: AppContext) : ExpoView(contex
terminalHandle = GhosttyBridge.nativeCreate(
cols,
rows,
terminalCanvas.cellWidthPx.toInt(),
terminalCanvas.cellHeightPx.toInt(),
cellSize.first,
cellSize.second,
foregroundColorValue,
backgroundColorValue,
cursorColorValue,
Expand Down
Loading