fix(web): clear stale provider update toast action

[mason50x]

What changed

• Clear the provider (Codex, OpenCode, etc) update toast's original Update action when it enters loading or success.
• Add focused coverage for both states in testing.

Why

UI shallow-merges toast updates. The initial prompt supplies actionProps, but the loading and success updates previously omitted that field, so the stale Update button remained visible while the command ran and after completion.

Explicitly setting actionProps: undefined removes the stale control. Failed and unchanged states still provide their intended Settings action.

Related work

This overlaps #3563 and #2655, which contain the same core one-line fix. This version is based on current main after the notification split into ProviderUpdatePrimaryNotification.tsx and adds regression coverage for both affected states.

Validation

• vp test run apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts apps/web/src/components/ProviderUpdateEnvironmentRows.test.tsx — 49 tests passed
• Targeted vp lint
• Targeted vp fmt --check
• vp run --filter @t3tools/web typecheck
• git diff --check

OpenCode was downgraded from 1.18.7 to 1.18.6 locally to leave a natural update-available state for manual verification.

Summary by CodeRabbit

• Bug Fixes

  • Prevented outdated “Update” actions from persisting in provider update notifications after they transition to loading or success states.

• Tests

  • Added coverage to verify notification updates correctly clear obsolete action controls.

---

Note

Low Risk
Small UI toast behavior fix with regression tests; no auth, data, or API changes.

Overview
Fixes provider update toasts that still showed the initial Update button while loading or after success.

updateProviderUpdateToast now passes actionProps: undefined on loading and success updates because Base UI shallow-merges toast state—omitting the field left the prompt’s action in place. Failed and unchanged states still set a Settings action.

The helper is exported and covered by a new unit test that checks actionProps for running, succeeded, failed, and unchanged views.

^{Reviewed by Cursor Bugbot for commit 2728487. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Clear stale action from provider update toast in loading and success states

When a provider update toast transitions to a loading or success state, any previously set action (e.g. a Settings button) was being retained due to shallow-merge behavior in toastManager.update. ProviderUpdatePrimaryNotification.tsx now explicitly sets actionProps to undefined in those branches to clear the stale action. A comment explaining the shallow-merge behavior is also added.

^{Macroscope summarized 2728487.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The provider update toast helper is exported, clears stale action properties during loading and success updates, and gains parameterized tests covering both phases.

Changes

Provider update toast

Layer / File(s)	Summary
Clear stale toast actions apps/web/src/components/ProviderUpdatePrimaryNotification.tsx, apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx	updateProviderUpdateToast is exported and sets actionProps to undefined for loading and success updates; tests verify this for both phases.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the core fix to stale provider update toast actions.
Description check	✅ Passed	The description covers what changed, why, related work, and validation, with only optional template sections omitted.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mason50x]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

🧹 Nitpick comments (1)

apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx (1)

23-55: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover the preserved Settings-action states.

This parameterized test only covers loading and success. Add failed/unchanged cases asserting the Settings action and onClick callback remain present, so future toast-update changes cannot regress the preservation contract.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx` around
lines 23 - 55, Extend the parameterized test for updateProviderUpdateToast to
include failed and unchanged view states, supplying the expected Settings action
and openSettings callback. Assert that toastMocks.update preserves both the
Settings action and its onClick callback in those states, while retaining the
existing loading and succeeded expectations.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx`:
- Around line 23-55: Extend the parameterized test for updateProviderUpdateToast
to include failed and unchanged view states, supplying the expected Settings
action and openSettings callback. Assert that toastMocks.update preserves both
the Settings action and its onClick callback in those states, while retaining
the existing loading and succeeded expectations.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ebadd67f-0edf-4c5f-ad62-e027b2e20c94

📥 Commits

Reviewing files that changed from the base of the PR and between d2d40b6 and 124690e.

📒 Files selected for processing (2)

• apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx
• apps/web/src/components/ProviderUpdatePrimaryNotification.tsx

[macroscopeapp]

Approvability

Verdict: Approved

Straightforward bug fix that explicitly clears stale toast action buttons during loading/success states. The change is small, well-documented with comments, and includes comprehensive test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}