FEAT: add Plan tab to right panel picker - #5549
Conversation
Add an entry point for the task/plan panel in the right panel's empty state and the "+" add-surface menu, alongside Diff/Browser/Files/ Terminal/Agents. Previously the plan panel could only appear automatically when steps arrived, with no manual way to open it.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved d73fc48 This PR adds a UI entry point for an existing 'Plan' panel feature, following the exact same pattern used for other panel types (browser, terminal, diff, files, agents). The changes are purely additive, self-contained, and don't introduce new runtime behavior. You can customize Macroscope's approvability policy. Learn more. |
addPlanSurface opened the plan panel without clearing the dismissal flag, so if the plan had been dismissed earlier in the turn, opening it manually from the empty state or "+" menu wouldn't clear it and could block the panel from auto-opening for later plan steps.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a121143. Configure here.
| clearPlanSidebarDismissal(activeThreadKey); | ||
| } | ||
| useRightPanelStore.getState().open(activeThreadRef, "plan"); | ||
| }, [activeThreadKey, activeThreadRef]); |
There was a problem hiding this comment.
Plan tab opens removed surface
High Severity
addPlanSurface opens the plan right-panel kind and clears dismissal via clearPlanSidebarDismissal, but that surface was removed in rightPanelStore v9. Plans now render inline, migration still drops plan surfaces, rightPanelContent has no plan branch, and PlanSidebar / the dismissal helper are gone—so the new Plan picker entry cannot open a working plan tab.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit a121143. Configure here.
|
Superseded by #5558, which deliberately removed the Plan right-panel surface and replaced it with inline, collapsible plan rows in the transcript. After that merge, this PR's picker entry targets a surface kind that no longer exists, so restoring it would undo the current UX architecture. Closing rather than reintroducing the removed sidebar. |
1 participant
Summary
onAddPlanhandler throughChatView.tsxthat opens the existingplanright-panel surface (PlanSidebar.tsx) for the active thread.Test plan
pnpm --filter web typecheckNote
Low Risk
UI-only wiring to an existing plan surface and dismissal helper; no auth, data, or backend changes.
Overview
Users can now open the plan/task panel on demand from the right panel, instead of relying only on automatic appearance when plan steps arrive.
ChatViewaddsaddPlanSurface, which clears any per-thread plan sidebar dismissal and opens the existing"plan"right-panel surface for the active thread.RightPanelTabswires this through a newonAddPlanprop in both the empty-state action cards and the "+" add-surface menu (desktop and sheet layouts), with a Plan entry using the clipboard-list icon.Reviewed by Cursor Bugbot for commit a121143. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Plan tab to the right panel picker
Adds a 'Plan' entry to both the right panel tab bar menu and the empty state action cards in RightPanelTabs.tsx. When selected, ChatViewContent clears any per-thread plan sidebar dismissal and opens the
plansurface in the right panel.Macroscope summarized a121143.