Skip to content

fix(web): restore typography font sizes to defaults - #6172

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
StiensWout:t3code/add-typography-reset-default
Aug 11, 2026
Merged

fix(web): restore typography font sizes to defaults#6172
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
StiensWout:t3code/add-typography-reset-default

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Changing only a typography font size left no way to restore the row because the reset affordance only tracked custom font families. The bulk restore action also ignored size-only overrides.

Typography rows now show the existing reset action whenever either their family or size differs from the default, and reset both values together. The bulk restore action now detects and restores all typography sizes too.

Screenshots

Default state Size override with reset affordance
Typography at the default interface font size Typography at 18 pixels with Reset to default visible

Verification

  • SettingsPanels.logic.test.ts: 13 tests passed
  • Web typecheck passed
  • Targeted lint passed
  • Playwright verified a size-only override reveals the reset action, restores 16 px, and hides the action again

Implemented by GPT-5.6 Sol using Codex in T3 Code.


Note

Low Risk
Settings UI and restore logic only; no auth, data, or API changes.

Overview
Typography settings reset only considered font families, so changing only a font size left no per-row reset and Restore Defaults did not list or clear size overrides.

Per-row reset on Interface, Prompt, Code, and Terminal now appears when either family or size differs from DEFAULT_UNIFIED_SETTINGS, and resets both together. Bulk restore includes the four fontSize* keys and uses a new getChangedTypographySettingLabels helper so changed labels treat each row as one unit (family or size).

Reviewed by Cursor Bugbot for commit 0110173. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restore typography font sizes to defaults alongside font families in settings

  • Font size settings (fontSizeInterface, fontSizePrompt, fontSizeCode, fontSizeTerminal) are now included when restoring typography defaults, fixing a gap where only font families were reset.
  • The reset button on each font row now appears when either the family or size differs from its default, and resets both together.
  • getChangedTypographySettingLabels is introduced in SettingsPanels.logic.ts to detect changed typography rows by checking both family and size against DEFAULT_UNIFIED_SETTINGS.

Macroscope summarized 0110173.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e08d3f7-be4e-48e3-b2d7-534bf7ac0fec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 11, 2026
Comment thread apps/web/src/components/settings/SettingsPanels.tsx
@macroscopeapp

macroscopeapp Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 0110173

Straightforward bug fix completing the typography restore-to-defaults feature by including font sizes alongside font families. Changes are isolated to settings panel UI, include unit tests, and the author has significant prior contributions to this exact feature area.

You can customize Macroscope's approvability policy. Learn more.

@StiensWout
StiensWout force-pushed the t3code/add-typography-reset-default branch from 09e3f95 to 0110173 Compare August 11, 2026 14:21
@juliusmarminge
juliusmarminge merged commit ac4780f into pingdotgg:main Aug 11, 2026
18 checks passed
xiaogwu pushed a commit to xiaogwu/t3code that referenced this pull request Aug 11, 2026
Brings in 7 upstream commits, including two that touch the same code as the
pinned-reorder work: Copy Thread ID in the thread context menu (pingdotgg#5574) and
shift+click new-thread-in-project (pingdotgg#5994). Merged clean, no conflicts.

Also picks up the hourly past-24h usage view (pingdotgg#6170), the GitLab self-hosted
remote routing fix (pingdotgg#6061), mobile composer stabilisation (pingdotgg#5986), the App
Store release version guard (pingdotgg#6177), and the typography font-size default
restore (pingdotgg#6172). pnpm-workspace.yaml, pnpm-lock.yaml and four patches/ files
changed, so this needs a fresh install before it builds.
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 11, 2026
## What's Changed
* feat: add ability to create a new thread in the current project with shift+click and show shortcut in tooltip by @UtkarshUsername in pingdotgg/t3code#5994
* feat(web): add Copy Thread ID to the sidebar and chat header thread context menu by @UtkarshUsername in pingdotgg/t3code#5574
* fix(mobile): stabilize thread composer and interactions by @juliusmarminge in pingdotgg/t3code#5986
* Add hourly past-24-hour usage view by @juliusmarminge in pingdotgg/t3code#6170
* fix(mobile): guard App Store release versions by @juliusmarminge in pingdotgg/t3code#6177
* fix(web): restore typography font sizes to defaults by @StiensWout in pingdotgg/t3code#6172


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260811.1067...v0.0.34-nightly.20260811.1068

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260811.1068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants