fix(web): restore typography font sizes to defaults - #6172
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 0110173 Straightforward bug fix completing the typography restore-to-defaults feature by including font sizes alongside font families. Changes are isolated to settings panel UI, include unit tests, and the author has significant prior contributions to this exact feature area. You can customize Macroscope's approvability policy. Learn more. |
09e3f95 to
0110173
Compare
Brings in 7 upstream commits, including two that touch the same code as the pinned-reorder work: Copy Thread ID in the thread context menu (pingdotgg#5574) and shift+click new-thread-in-project (pingdotgg#5994). Merged clean, no conflicts. Also picks up the hourly past-24h usage view (pingdotgg#6170), the GitLab self-hosted remote routing fix (pingdotgg#6061), mobile composer stabilisation (pingdotgg#5986), the App Store release version guard (pingdotgg#6177), and the typography font-size default restore (pingdotgg#6172). pnpm-workspace.yaml, pnpm-lock.yaml and four patches/ files changed, so this needs a fresh install before it builds.
## What's Changed * feat: add ability to create a new thread in the current project with shift+click and show shortcut in tooltip by @UtkarshUsername in pingdotgg/t3code#5994 * feat(web): add Copy Thread ID to the sidebar and chat header thread context menu by @UtkarshUsername in pingdotgg/t3code#5574 * fix(mobile): stabilize thread composer and interactions by @juliusmarminge in pingdotgg/t3code#5986 * Add hourly past-24-hour usage view by @juliusmarminge in pingdotgg/t3code#6170 * fix(mobile): guard App Store release versions by @juliusmarminge in pingdotgg/t3code#6177 * fix(web): restore typography font sizes to defaults by @StiensWout in pingdotgg/t3code#6172 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260811.1067...v0.0.34-nightly.20260811.1068 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260811.1068
Changing only a typography font size left no way to restore the row because the reset affordance only tracked custom font families. The bulk restore action also ignored size-only overrides.
Typography rows now show the existing reset action whenever either their family or size differs from the default, and reset both values together. The bulk restore action now detects and restores all typography sizes too.
Screenshots
Verification
SettingsPanels.logic.test.ts: 13 tests passedImplemented by GPT-5.6 Sol using Codex in T3 Code.
Note
Low Risk
Settings UI and restore logic only; no auth, data, or API changes.
Overview
Typography settings reset only considered font families, so changing only a font size left no per-row reset and Restore Defaults did not list or clear size overrides.
Per-row reset on Interface, Prompt, Code, and Terminal now appears when either family or size differs from
DEFAULT_UNIFIED_SETTINGS, and resets both together. Bulk restore includes the fourfontSize*keys and uses a newgetChangedTypographySettingLabelshelper so changed labels treat each row as one unit (family or size).Reviewed by Cursor Bugbot for commit 0110173. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Restore typography font sizes to defaults alongside font families in settings
fontSizeInterface,fontSizePrompt,fontSizeCode,fontSizeTerminal) are now included when restoring typography defaults, fixing a gap where only font families were reset.getChangedTypographySettingLabelsis introduced inSettingsPanels.logic.tsto detect changed typography rows by checking both family and size againstDEFAULT_UNIFIED_SETTINGS.Macroscope summarized 0110173.