Skip to content

fix(web): use upload icon for disabled push action - #6207

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/web-disabled-push-icon
Aug 11, 2026
Merged

fix(web): use upload icon for disabled push action#6207
juliusmarminge merged 1 commit into
mainfrom
fix/web-disabled-push-icon

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • use the upload icon for the disabled Push quick action, matching the enabled push state

Why

The disabled push action fell back to the generic info icon, so the same action changed meaning visually depending on availability.

UI Changes

Before After
Disabled Push before Disabled Push after

Verified in the real app on the demo-project new thread draft workflow at 1440x1000. The latest base did not change this component after the before capture.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • No animation or interaction changed

Built with Codex on T3 Code.


Note

Cursor Bugbot is generating a summary for commit cd17a87. Configure here.

Note

Fix disabled Push action to show upload icon in GitQuickActionIcon

The GitQuickActionIcon component in GitActionsControl.tsx was falling through to a generic InfoIcon for Push actions. A new conditional branch now returns CloudUploadIcon when the quick action label is 'Push'.

Macroscope summarized cd17a87.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 11, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved cd17a87

Simple UI fix adding a CloudUploadIcon for the disabled Push action, following the exact pattern used for other action icons. Pure visual change with no behavioral impact.

You can customize Macroscope's approvability policy. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.3 KiB 11.3 KiB −4 B (−0.0%) 15.1 KiB
Codex Thread snapshot wire 5.5 KiB 5.5 KiB −12 B (−0.2%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB +8 B (+0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 11.3 KiB 11.3 KiB +1 B (+0.0%) 15.1 KiB
Claude Thread snapshot wire 5.5 KiB 5.5 KiB +1 B (+0.0%) 7.3 KiB
Claude Live turn WebSocket wire 5.8 KiB 5.8 KiB 0 B (0.0%) 7.8 KiB
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 083fa4a · PR result: cd17a87 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge merged commit 2db0845 into main Aug 11, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the fix/web-disabled-push-icon branch August 11, 2026 18:25
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 11, 2026
y5 pushed a commit to y5/t3code that referenced this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant