Skip to content

fix(web): remove projects with archived threads - #6225

Closed
ipanasenko wants to merge 4 commits into
pingdotgg:mainfrom
ipanasenko:fix/remove-project-with-archived-threads
Closed

fix(web): remove projects with archived threads#6225
ipanasenko wants to merge 4 commits into
pingdotgg:mainfrom
ipanasenko:fix/remove-project-with-archived-threads

Conversation

@ipanasenko

@ipanasenko ipanasenko commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Problem

Project removal counted only unarchived threads from the live shell snapshot. A project containing only archived threads therefore appeared empty, sent a non-forced delete command, and failed the server invariant instead of being removed.

image

Fix

  • always force thread deletion after the user confirms project removal in Settings or the sidebar
  • make the destructive confirmation and checkout count explicit about archived versus unarchived threads
  • document that removing a project clears all conversation history but leaves workspace files on disk
  • add a regression test for the archived-only case
image

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

Note

Fix project deletion to include archived threads by always passing force: true

  • Adds a projectDeleteCommandInput helper in projectRemoval.ts that always returns { projectId, force: true }, since archived threads are absent from live shell snapshots and require a forced delete.
  • Updates project removal flows in LegacySidebar.tsx and ProjectSettingsPanel.tsx to use this helper, removing previous conditional logic around the force flag.
  • Updates confirmation dialog copy in both components to explicitly state that all threads, including archived ones, will be permanently deleted.
  • Behavioral Change: Projects that previously failed to remove archived threads will now have all associated threads deleted on removal.
📊 Macroscope summarized 2a918c2. 2 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

Archived threads are omitted from the live shell snapshot, so project removal incorrectly skipped force deletion when no unarchived threads were visible. Always force confirmed project deletion and make the destructive copy explicit.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 19d0d78e-ddd4-495c-8e61-f0337b5b262d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 11, 2026
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 11, 2026
Comment thread apps/web/src/components/settings/ProjectSettingsPanel.tsx Outdated
@t3dotgg

t3dotgg commented Sep 4, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-6 Astra (preview) responding on behalf of Theo

This was closed as part of an automated cleanup pass. If you believe it was closed in error, reply here and we will get it reopened.

Closing as superseded by #8798, which is on main. Project removal now warns that archived history will be deleted and sends force: true after confirmation. It no longer needs a complete archive snapshot to remove the project, so this additional archive-read path is not needed.

@t3dotgg t3dotgg closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants