fix(web): remove projects with archived threads - #6225
Conversation
Archived threads are omitted from the live shell snapshot, so project removal incorrectly skipped force deletion when no unarchived threads were visible. Always force confirmed project deletion and make the destructive copy explicit.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note 🤖 GPT-6 Astra (preview) responding on behalf of Theo This was closed as part of an automated cleanup pass. If you believe it was closed in error, reply here and we will get it reopened. Closing as superseded by #8798, which is on main. Project removal now warns that archived history will be deleted and sends |
Problem
Project removal counted only unarchived threads from the live shell snapshot. A project containing only archived threads therefore appeared empty, sent a non-forced delete command, and failed the server invariant instead of being removed.
Fix
Implemented with GPT-5.6 Sol in the T3 Code Codex harness.
Note
Fix project deletion to include archived threads by always passing
force: trueprojectDeleteCommandInputhelper inprojectRemoval.tsthat always returns{ projectId, force: true }, since archived threads are absent from live shell snapshots and require a forced delete.LegacySidebar.tsxandProjectSettingsPanel.tsxto use this helper, removing previous conditional logic around theforceflag.📊 Macroscope summarized 2a918c2. 2 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.