fix(web): keep sidebar wordmark visible at minimum width - #6246
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d83de80 to
0c5a522
Compare
ApprovabilityVerdict: Approved 0c5a522 This is a simple CSS fix removing a container query condition so the sidebar wordmark stays visible at minimum width. The change is purely visual with no runtime behavior impact, and includes test coverage for regression prevention. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(web): clean up composer resize animation by @extoci in pingdotgg/t3code#6209 * feat(web): compact sidebar footer actions by @maria-rcks in pingdotgg/t3code#6210 * fix(web): keep sidebar wordmark visible at minimum width by @extoci in pingdotgg/t3code#6246 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260811.1071...v0.0.34-nightly.20260812.1072 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1072
What Changed
Why
At the 13rem sidebar minimum, the desktop sidebar border can leave the header query container slightly narrower than 13rem. As a result, both the original 13.5rem query and an exact 13rem query hide the wordmark on web, Windows (no traffic lights to account for), and macOS even though the wordmark still fits.
Showing the wordmark unconditionally inside the existing desktop media query avoids the border and fractional-rounding boundary. The optional environment label keeps its separate container query.
UI Changes
Before
Screen.Recording.2026-08-12.at.2.38.19.AM.mov
Afte
Screen.Recording.2026-08-12.at.2.41.59.AM.mov
Verification
vp test run apps/web/src/components/threadSidebarWidth.test.ts apps/web/src/components/SidebarStageBackdrop.test.tsx— 14 tests passedvp run --filter @t3tools/web typecheck— passedChecklist
Generated with GPT-5.6-sol using the Codex harness in T3 Code.
Note
Low Risk
UI-only CSS visibility tweak plus a focused regression test; no auth, data, or layout contract changes beyond wordmark display.
Overview
Keeps the desktop T3 Code wordmark visible across the full legal sidebar width range, including the
13remminimum.Removes the redundant
@container sidebar-header (min-width: 13.5rem)gate on.sidebar-brand, so the wordmark shows whenever the desktop media query applies. The optional stage label still uses its wider15.75remcontainer threshold.Adds a regression test that reads
index.cssand asserts brand visibility rules stay aligned withTHREAD_SIDEBAR_MIN_WIDTH.Reviewed by Cursor Bugbot for commit 0c5a522. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix sidebar wordmark visibility at minimum width on desktop
Previously,
.sidebar-brandwas only shown when thesidebar-headercontainer was at least13.5remwide, causing the wordmark to disappear at minimum sidebar widths. The fix removes the container-width gate and makes.sidebar-brandunconditionallydisplay: flexwithin the@media (min-width: 48rem)desktop breakpoint. The.sidebar-brand-stagelabel remains gated by@container sidebar-header (min-width: 15.75rem). A new test in threadSidebarWidth.test.ts validates the CSS rules againstTHREAD_SIDEBAR_MIN_WIDTH.Macroscope summarized 0c5a522.