-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(web): reject oversized prompts before provider turn start #6602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 4 commits into
pingdotgg:main
from
naveed949:codex/6105-oversized-prompts
Aug 15, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9fa4786
fix(web): reject oversized composer prompts
naveed949 c3609db
fix(web): align composer validation paths
naveed949 16f7778
fix(web): validate composed provider prompts
naveed949 8cc9ca3
fix(web): keep rejected composer sends focused
naveed949 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
apps/web/src/components/chat/ComposerPromptLengthValidation.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { PROVIDER_SEND_TURN_MAX_INPUT_CHARS } from "@t3tools/contracts"; | ||
| import { renderToStaticMarkup } from "react-dom/server"; | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
|
|
||
| import { getComposerPromptLengthValidationMessage } from "./composerSubmission"; | ||
| import { ComposerPromptLengthValidation } from "./ComposerPromptLengthValidation"; | ||
|
|
||
| describe("ComposerPromptLengthValidation", () => { | ||
| it("renders oversized prompt feedback as an actionable composer alert", () => { | ||
| const message = getComposerPromptLengthValidationMessage( | ||
| "x".repeat(PROVIDER_SEND_TURN_MAX_INPUT_CHARS + 1), | ||
| ); | ||
|
|
||
| const markup = renderToStaticMarkup(<ComposerPromptLengthValidation message={message} />); | ||
|
|
||
| expect(markup).toContain('role="alert"'); | ||
| expect(markup).toContain('data-chat-composer-validation="prompt-length"'); | ||
| expect(markup).toContain( | ||
| "Prompt is 1 character over the 120,000-character limit. Shorten or split it before sending.", | ||
| ); | ||
| expect(markup).not.toContain("ProviderValidationError"); | ||
| }); | ||
| }); |
13 changes: 13 additions & 0 deletions
13
apps/web/src/components/chat/ComposerPromptLengthValidation.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| export function ComposerPromptLengthValidation({ message }: { message: string | null }) { | ||
| if (!message) return null; | ||
|
|
||
| return ( | ||
| <p | ||
| role="alert" | ||
| className="px-3 pb-2 text-xs text-destructive sm:px-4" | ||
| data-chat-composer-validation="prompt-length" | ||
| > | ||
| {message} | ||
| </p> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.