fix(search): oversized thread queries no longer crash clients

[Lucenx9]

What Changed

Thread content search could throw in web and mobile when a query exceeded the 200-character contract limit because the shared atom decoded its cache key synchronously.

Search keys are now decoded safely from JSON at the shared client-runtime boundary. Out-of-contract or malformed keys return an empty content-search state without issuing environment requests, while valid queries and local title matching continue unchanged. Boundary tests cover maximum-length normalization, oversized queries, and malformed JSON.

Why

A long query typed into the command palette or mobile thread search could abort client rendering. Treating out-of-contract content searches as empty keeps both clients usable and preserves the server's existing bounded-query contract.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes (not applicable; no UI changes)
• I included a video for animation/interaction changes (not applicable; no animation or interaction changes)

Created with gpt-5.6-sol using the Codex harness in T3 Code.

Note

Fix oversized or malformed thread search keys to return empty state instead of crashing

• ThreadSearchKey schema in threadSearch.ts now decodes via Schema.decodeUnknownOption, returning None on invalid input instead of throwing.
• createThreadSearchResultsAtomFamily returns { matches: [], isLoading: false } immediately when the key parses to None, skipping any search invocation.
• Tests added in threadSearch.test.ts covering boundary-length valid keys and over-length/malformed keys.

^{Macroscope summarized 12faef0.}

---

Note

Low Risk
Localized defensive change in shared search state with tests; no auth, data, or API contract changes beyond avoiding client crashes.

Overview
Thread content search in client-runtime no longer throws when a cache key is out of contract or malformed.

threadSearch.ts decodes search keys with Schema.fromJsonString and decodeUnknownOption instead of JSON.parse plus synchronous decode. Keys that fail validation (e.g. query over the 200-character limit) or invalid JSON yield { matches: [], isLoading: false } and do not call per-environment search atoms.

threadSearch.test.ts adds coverage for max-length valid keys (including trimmed whitespace) and for over-length and malformed keys asserting zero search invocations.

^{Reviewed by Cursor Bugbot for commit 12faef0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 191e31ba-3d4a-44fd-80ba-3d9b266059fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 12faef0

This is a straightforward defensive bug fix that prevents client crashes from invalid search queries. The change switches from throwing exceptions to gracefully returning empty results for malformed inputs, with comprehensive test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

[CDVolvik]

threadSearch.test.ts: 6/6. Keys at 200 chars still search; 201 and malformed JSON return empty and do not call getSearchAtom.

Schema.fromJsonString + decodeUnknownOption replaces JSON.parse that could throw into the atom. That is the crash. MERGEABLE.