feat(web): refresh pull request details - #7148
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces new features including stacked pull request detection (with LayersIcon indicators), clickable repository links that open externally, and changes the priority logic for action buttons. The scope of new user-facing behavior and UI restructuring warrants human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
Reviewed the pull-request chrome rework against the shared primitive/Tailwind ownership rules. The primitive migrations look sound (SegmentedTab* for the tabs, Button behind MenuTrigger render in the filters menu with --control-icon-color carrying the pressed tone, WorkspacePageHeader/WorkspacePageContainer keeping drag-region, WCO inset and the collapsed-sidebar titlebar inset, ps-[8.5px] matching the existing leading-icon button call sites). Two layout regressions introduced by changed lines are noted inline.
Posted via Macroscope — UI Consistency
8c3da41 to
89fac2a
Compare
There was a problem hiding this comment.
One new finding on the conflict primary action. The two findings from the previous run (tab-nav padding vs. scroll compensation, and MetaRow losing its vertical padding) are still open on the current head and are not repeated here.
Posted via Macroscope — UI Consistency
89fac2a to
b45d74e
Compare
b45d74e to
1dd5875
Compare
1dd5875 to
0437edb
Compare
0437edb to
5cc755c
Compare
There was a problem hiding this comment.
One finding on the reworked pull request detail header. Details inline.
Posted via Macroscope — UI Consistency
da3f3d2 to
9d9746a
Compare
9d9746a to
02917c5
Compare
There was a problem hiding this comment.
One consistency issue found in the reworked pull request chrome. Everything previously raised (segmented track classes now live in the ToggleGroup primitive, the disabled-toggle tooltip wrappers, the copy-branch focus ring, the xs icon sizing, MetaRow padding, action-row DOM order, and the restored collapse rationale comments) is addressed at this head.
Posted via Macroscope — UI Consistency
bd7ac13 to
210047d
Compare
There was a problem hiding this comment.
One consistency finding in this revision. Everything else in the restructure lines up with the shared primitives: the segmented tab group now takes its track from the segmented variant, the filters trigger renders through Button, the panel header goes through WorkspacePageHeader/WorkspacePageContainer, both disabled panel toggles hang their tooltip on a wrapper (matching ConnectionsSettings), and the detail ghost mirrors the new chrome and MetaRow grid.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One finding: the new stacked-base indicator has no user-facing explanation. Everything else in this pass looks consistent with the shared primitives — the tooltip triggers on the disabled panel toggles are now wrapped uniformly, the segmented track lives in ToggleGroup rather than the call site, the filter/refresh controls go through Button, and the header/container geometry comes from WorkspacePageHeader/WorkspacePageContainer.
Posted via Macroscope — UI Consistency
210047d to
f1c8120
Compare
There was a problem hiding this comment.
One finding on the rebuilt detail-panel chrome: the top row's crossfading layers lost their sm:text-xs step. Everything else checked out — the panel-layout tooltip triggers, the filters trigger migration to Button, the segmented tab group, and the MetaRow/ghost geometry all line up with the shared primitives.
Posted via Macroscope — UI Consistency
1088b81 to
75f0625
Compare
75f0625 to
eee6a04
Compare
(cherry picked from commit a850895)
## What's Changed * fix(desktop): stop automatic passkey prompts by @t3dotgg in pingdotgg/t3code#7522 * fix(web): align version text with its label by @RakshithBhat03 in pingdotgg/t3code#7521 * fix(web): refresh open file with the file tree by @StiensWout in pingdotgg/t3code#7490 * Add OpenCode skill discovery by @dbalders in pingdotgg/t3code#3154 * feat(web): unify workspace navigation by @maria-rcks in pingdotgg/t3code#7153 * fix(web): hide opencode's plan agent when legacy plan mode is off by @UtkarshUsername in pingdotgg/t3code#6420 * feat: refine thread action menus by @maria-rcks in pingdotgg/t3code#7476 * feat(web): redesign usage insights by @maria-rcks in pingdotgg/t3code#7147 * fix(server): outdated gh no longer reads as "not authenticated" by @t3dotgg in pingdotgg/t3code#7588 * fix(desktop): refresh queued updates before install by @SunkenInTime in pingdotgg/t3code#6269 * feat(web): confirm before closing a terminal by @maria-rcks in pingdotgg/t3code#7592 * feat(web): refresh pull request details by @maria-rcks in pingdotgg/t3code#7148 * fix(web): usage hourly breakdown lists every hour chronologically by @lgwacker in pingdotgg/t3code#7595 * fix(web): remove the terminal pane's app-canvas gutter by @jakeleventhal in pingdotgg/t3code#6222 * feat(web): attach composer state drawers by @maria-rcks in pingdotgg/t3code#7150 * fix(server): preserve tool lifecycle identity by @maria-rcks in pingdotgg/t3code#7151 * chore(desktop): use stable Clerk Electron release by @t3dotgg in pingdotgg/t3code#7602 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260819.1133...v0.0.34-nightly.20260820.1139 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260820.1139
Bring in T3 Code pingdotgg#7148 pingdotgg#7595 pingdotgg#6222 pingdotgg#7150 pingdotgg#7151 pingdotgg#7602 pingdotgg#7152 so the fork is not behind pingdotgg/t3code:main. Co-authored-by: Cursor <cursoragent@cursor.com>
What changed
Screenshots
Direct parent on the left; this PR on the right. Same viewport and copied application state.
This is a large visual review on its own. Separating it keeps workspace primitives below and terminal, composer, and tool-call behavior out of the diff.
Validation
Stack order
Built with GPT-5.6-sol in the Codex harness.
Note
Medium Risk
Large UI refactor across PR detail, list, and VCS/ref parsing; conflict action ordering and new stacked-PR heuristics affect merge/checkout flows, though logic is covered by added tests.
Overview
Pull request detail and list get a visual and interaction pass: shared
WorkspacePageHeader/WorkspacePageContainer, filter and refresh controls aligned with other workspace pages, and the right-panel toggle only when a PR is selected (with a clearer unavailable tooltip).PullRequestDetailPaneldrops thechromeVariantprop and always collapses header metadata on scroll, with tighter top chrome and segmented tab toggles. Resolve conflicts becomes the primary header action when merge conflicts exist (ahead of draft-ready / merge). The repository name can open the repo root via newchangeRequestRepositoryUrl. Stacked PRs are inferred from local VCS refs (isStackedPullRequestBase) and shown with a layers icon on the base branch. Loading uses a full-panelPullRequestDetailGhostinstead of per-tab ghosts inside the scroll area.PanelLayoutControlswraps disabled toggles so tooltips still work on unavailable terminal/right-panel buttons.pullRequestHandoffLabelsno longer exposes resolve/conflicts strings (conflicts are handled in the header). Summary meta rows use a fixed label column grid.Reviewed by Cursor Bugbot for commit eee6a04. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Refresh pull request detail panel with conflict resolution, stacked PR indicators, and usage page redesign
ToggleGroup, and the repository label becomes a clickable external link.isStackedPullRequestBasehelper and a VCS refs query to detect stacked PRs, showing aLayersIconindicator in the header when the base branch is not the repo default.sessionstracking tomergeUsageso providers with sessions but zero spend appear in the provider list.changeRequestRepositoryUrlto derive a repository root URL from a PR URL across GitHub, GitLab, Bitbucket, and Azure DevOps.PanelLayoutControlstooltips stay accessible when toggles are disabled; the right-panel toggle on the pull requests route requires an active PR selection.pullRequestHandoffLabelsno longer returnsresolveorresolveConflictskeys; callers that depended on those entries will receive only fix-related labels.Macroscope summarized 75f0625.