fix(web): align Windows update confirmation copy - #7208
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 6120bd1 This PR removes Windows-specific copy from the update confirmation dialog, simplifying to consistent messaging across all platforms. The changes are limited to UI text and test updates with no runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(mobile): keep sheet actions below status bar by @NitayRabi in pingdotgg/t3code#6635 * fix(web): align Windows update confirmation copy by @StiensWout in pingdotgg/t3code#7208 ## New Contributors * @NitayRabi made their first contribution in pingdotgg/t3code#6635 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260816.1109...v0.0.34-nightly.20260816.1110 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260816.1110
Windows update confirmations still warned that T3 Code could remain closed for several minutes, even though install times have improved and other desktop platforms already use the shorter shared message.
This removes the stale Windows-only warning and its platform-specific helper branch, so Windows now uses the existing Mac/Linux confirmation copy across all three update entry points. Focused coverage now asserts the shared confirmation text.
Tests:
pnpm exec vp test run apps/web/src/components/desktopUpdate.logic.test.ts;pnpm exec vp fmt --check ...;pnpm exec vp lint --report-unused-disable-directives ...;pnpm --filter @t3tools/web typecheck.Model/harness: GPT-5.6 Luna via the Codex harness in T3 Code.
Note
Low Risk
Copy-only change to desktop update confirmation dialogs with no auth, data, or updater behavior changes.
Overview
Removes the Windows-only extra text in the desktop update install confirmation dialog (long silent-install warning) so all platforms use the same short message about restarting and interrupting tasks.
getDesktopUpdateInstallConfirmationMessageno longer takes a platform argument or branches on Windows; LegacySidebar, SettingsPanels, and SidebarUpdatePill call it with update state only. Tests now assert one shared confirmation string instead of separate Windows vs Mac expectations.Reviewed by Cursor Bugbot for commit 6120bd1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove Windows-specific copy from desktop update confirmation dialog
The
getDesktopUpdateInstallConfirmationMessagefunction previously appended a Windows-specific silent installation warning based onnavigator.platform. It now returns a single, platform-agnostic confirmation message on all platforms. Callers in LegacySidebar.tsx, SidebarUpdatePill.tsx, and SettingsPanels.tsx no longer pass a platform argument.Macroscope summarized 6120bd1.