fix(mobile): rotate snoozed and settled shelf chevrons - #7276
Conversation
Both shelf headers swapped between the chevron.up and chevron.down SF Symbols based on expanded state, but the native symbol view does not redraw when only the symbol name changes, so the chevrons stayed frozen at their initial direction and pointed opposite ways relative to each other. Match the disclosure-chevron convention used elsewhere in the app (ConnectionEnvironmentRow, CloudEnvironmentRows): keep a single chevron.down symbol and rotate it 180deg when expanded.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved b8d1176 Minor UI adjustment that changes chevron icons to animate via rotation instead of swapping icons. The change is purely cosmetic, self-contained, and has no impact on business logic or runtime behavior. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(mobile): rotate snoozed and settled shelf chevrons by @lnieuwenhuis in pingdotgg/t3code#7276 * fix(web): show all usage breakdown periods by @tris203 in pingdotgg/t3code#7219 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260817.1119...v0.0.34-nightly.20260817.1120 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260817.1120
The Snoozed and Settled shelf chevrons on the mobile threads list never moved and pointed in opposite directions: both headers swapped between the
chevron.up/chevron.downSF Symbols based on expanded state, but the native symbol view does not redraw when only the symbol name changes, so each chevron stayed frozen at whatever direction it first rendered.Fixed by matching the disclosure-chevron convention already shipped in
ConnectionEnvironmentRowandCloudEnvironmentRows: keep a singlechevron.downsymbol and rotate it 180° with a state-driven style transform. Both headers now follow the same rule (down when collapsed, up when expanded) and give feedback on every tap. No continuous animation — the transform only changes with the expanded state.Before: the issue's screenshots (fig1–fig3 at https://t3code-chevron-shots.pages.dev/) show Snoozed open pointing down while Settled closed points up. After-screenshots were not captured — this change was made without simulator access; happy to add them on request.
Verification:
vp run typecheckinapps/mobile(exit 0) andvp linton the changed file (0 warnings). No test exists for this presentational component and no behavior contract changed, so none was added.Fixes #7121
Claude Fable 5 via Claude Code
Note
Low Risk
Presentational-only change to two shelf header icons; no logic, API, or data handling.
Overview
Snoozed and Settled thread-list shelf headers now show chevrons that actually flip when you expand or collapse the section.
Both headers used to swap SF Symbol names (
chevron.up/chevron.down) withexpanded, but the nativeSymbolViewdoes not reliably redraw when only the name changes, so the icons stayed stuck on their first render (and could point the wrong way).The fix matches ConnectionEnvironmentRow and CloudEnvironmentRows: always use
chevron.downand drive direction with a styletransformrotate (0degcollapsed,180degexpanded). No animation—only the transform updates with state.Reviewed by Cursor Bugbot for commit b8d1176. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Rotate snoozed and settled shelf chevrons on expand instead of swapping glyphs
Replaces the conditional
chevron.up/chevron.downglyph swap inThreadListV2SnoozedShelfHeaderandThreadListV2SettledShelfHeaderwith a CSS transform that rotates a fixedchevron.downicon 180° when expanded. This produces a smoother visual transition and removes the need for conditional icon names.Macroscope summarized b8d1176.