feat(desktop): choose external project icons - #7823
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Reviewed the web UI changes (ProjectFaviconPickerDialog.tsx, ProjectSettingsPanel.tsx). Two consistency findings: the palette footer "Open in " action is now duplicated verbatim (button treatment and label logic) instead of being shared with the command palette. Details inline.
Posted via Macroscope — UI Consistency
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a new feature allowing users to pick project icons from external filesystem locations, introducing new IPC channels, asset claim types, and UI components. New features with cross-cutting behavior changes warrant human review. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * feat(web): cmd+enter to create thread in background by @extoci in pingdotgg/t3code#7821 * fix(web): launcher shortcuts no longer hijack the empty composer by @Lucenx9 in pingdotgg/t3code#7794 * feat(desktop): choose external project icons by @Bil0000 in pingdotgg/t3code#7823 * perf(web): dedupe terminal mouse motion reports by @t3-code[bot] in pingdotgg/t3code#7845 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260821.1154...v0.0.34-nightly.20260822.1155 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260822.1155
What changed
Project icon picker now has
Open in Finder,Open in Explorer, orOpen in Files. This opens the native image picker, so the image can live outside the project.Why
Previously, users had to copy an image into the project before they could use it as the project icon. This adds the native picker without widening general workspace file access.
Before and after
Before
After
Verification
Checklist
Note
Add native external project favicon picker to desktop app
pickProjectFavicon(window.ts) that opens a single-file native image picker and returns the selected pathAssetAccess(AssetAccess.ts) to issue and resolve asset URLs for favicons stored outside the workspace, using a newproject-favicon-externalclaim kind with exact-path matchingProjectFaviconResolver(ProjectFaviconResolver.ts) to accept absolute filesystem paths as favicon candidates via afilesystemscopeProjectFaviconPickerDialog(ProjectFaviconPickerDialog.tsx), gated by platform and path consistency viacanPickExternalProjectFaviconElectronDialogPickFilesInputnow requires an explicitmultipleflag; existingpickFilescallers (e.g.pickThemeFiles) must pass it explicitlyMacroscope summarized 3b4b4bc.