test(desktop): remove redundant release note assertion - #7873
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Test-only change removing a redundant assertion. The subsequent line in the same test already validates the function doesn't throw by calling it and checking its return value. No runtime impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 22, 2026
## What's Changed * fix(web): command-click spaced folder links by @SunkenInTime in pingdotgg/t3code#6439 * fix(chat): stop pushing follow-up messages to the top by @t3dotgg in pingdotgg/t3code#7897 * test(desktop): remove redundant release note assertion by @t3-code[bot] in pingdotgg/t3code#7873 * fix(web): handle wide ordered-list marker edge cases by @abcdmku in pingdotgg/t3code#7856 ## New Contributors * @abcdmku made their first contribution in pingdotgg/t3code#7856 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260822.1159...v0.0.34-nightly.20260822.1160 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260822.1160
ohbentos
pushed a commit
to ohbentos/t3code
that referenced
this pull request
Aug 23, 2026
# This is the 1st commit message: fix: render workspace images in chat markdown (pingdotgg#6433) # This is the commit message pingdotgg#2: test(desktop): remove redundant release note assertion (pingdotgg#7873) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
frankdavidcorona
pushed a commit
to frankdavidcorona/t3code
that referenced
this pull request
Aug 23, 2026
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
cloudbridgeuy
pushed a commit
to cloudbridgeuy/t3code
that referenced
this pull request
Aug 23, 2026
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the out-of-range numeric entity test invoked
normalizeDesktopUpdateReleaseNotestwice with identical inputs. the first invocation only asserted that it did not throw, while the second asserted the exact returned release-note structure.this removes the redundant
not.toThrow()invocation. the remaining exact-value assertion necessarily fails if the same call throws and still verifies that the invalid entity is preserved, so behavior coverage is unchanged.verification:
./node_modules/.bin/vp test run apps/desktop/src/updates/releaseNotes.test.ts(1 file passed, 6 tests passed)./node_modules/.bin/vp test run apps/desktop/src/updates/releaseNotes.test.ts(1 file passed, 6 tests passed)./node_modules/.bin/vp run --filter @t3tools/desktop typecheck(passed with 2 pre-existing effect suggestions)./node_modules/.bin/vp lint --report-unused-disable-directives apps/desktop/src/updates/releaseNotes.test.ts(passed)./node_modules/.bin/vp fmt --check apps/desktop/src/updates/releaseNotes.test.ts(passed)git diff --check(passed)made by gpt-5.6-sol via hermes agent.
Note
Low Risk
Test-only cleanup with no production or security impact.
Overview
Removes a duplicate
not.toThrow()call in the out-of-range HTML entity test fornormalizeDesktopUpdateReleaseNotes. The remaining equality assertion still fails if the function throws and still checks that the invalid entity is kept as a literal.Reviewed by Cursor Bugbot for commit fdccd40. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove redundant
not.toThrowassertion fromnormalizeDesktopUpdateReleaseNotestestRemoves the explicit
expect(...).not.toThrow()assertion from the out-of-range numeric entities test in releaseNotes.test.ts. The test still verifies the returned notes content, which implicitly confirms no exception is thrown.Macroscope summarized fdccd40.