Skip to content

test(desktop): remove redundant release note assertion - #7873

Merged
maria-rcks merged 1 commit into
mainfrom
test/prune-useless-tests-20260822-040452
Aug 22, 2026
Merged

test(desktop): remove redundant release note assertion#7873
maria-rcks merged 1 commit into
mainfrom
test/prune-useless-tests-20260822-040452

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

the out-of-range numeric entity test invoked normalizeDesktopUpdateReleaseNotes twice with identical inputs. the first invocation only asserted that it did not throw, while the second asserted the exact returned release-note structure.

this removes the redundant not.toThrow() invocation. the remaining exact-value assertion necessarily fails if the same call throws and still verifies that the invalid entity is preserved, so behavior coverage is unchanged.

verification:

  • before: ./node_modules/.bin/vp test run apps/desktop/src/updates/releaseNotes.test.ts (1 file passed, 6 tests passed)
  • after: ./node_modules/.bin/vp test run apps/desktop/src/updates/releaseNotes.test.ts (1 file passed, 6 tests passed)
  • ./node_modules/.bin/vp run --filter @t3tools/desktop typecheck (passed with 2 pre-existing effect suggestions)
  • ./node_modules/.bin/vp lint --report-unused-disable-directives apps/desktop/src/updates/releaseNotes.test.ts (passed)
  • ./node_modules/.bin/vp fmt --check apps/desktop/src/updates/releaseNotes.test.ts (passed)
  • git diff --check (passed)

made by gpt-5.6-sol via hermes agent.


Note

Low Risk
Test-only cleanup with no production or security impact.

Overview
Removes a duplicate not.toThrow() call in the out-of-range HTML entity test for normalizeDesktopUpdateReleaseNotes. The remaining equality assertion still fails if the function throws and still checks that the invalid entity is kept as a literal.

Reviewed by Cursor Bugbot for commit fdccd40. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove redundant not.toThrow assertion from normalizeDesktopUpdateReleaseNotes test

Removes the explicit expect(...).not.toThrow() assertion from the out-of-range numeric entities test in releaseNotes.test.ts. The test still verifies the returned notes content, which implicitly confirms no exception is thrown.

Macroscope summarized fdccd40.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at fdccd40

Macroscope's review found this PR approvable — Test-only change removing a redundant assertion. The subsequent line in the same test already validates the function doesn't throw by calling it and checking its return value. No runtime impact.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.4 KiB 13.4 KiB +10 B (+0.1%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 6.9 KiB −4 B (−0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 6.6 KiB +14 B (+0.2%) 7.8 KiB
Codex Live turn WebSocket decoded 55.0 KiB 55.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 13.4 KiB 13.5 KiB +17 B (+0.1%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 6.9 KiB −1 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.6 KiB +18 B (+0.3%) 7.8 KiB
Claude Live turn WebSocket decoded 55.8 KiB 55.8 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 11f0513 · PR result: fdccd40 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@maria-rcks
maria-rcks merged commit 0ede2ed into main Aug 22, 2026
21 checks passed
@maria-rcks
maria-rcks deleted the test/prune-useless-tests-20260822-040452 branch August 22, 2026 14:30
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 22, 2026
## What's Changed
* fix(web): command-click spaced folder links by @SunkenInTime in pingdotgg/t3code#6439
* fix(chat): stop pushing follow-up messages to the top by @t3dotgg in pingdotgg/t3code#7897
* test(desktop): remove redundant release note assertion by @t3-code[bot] in pingdotgg/t3code#7873
* fix(web): handle wide ordered-list marker edge cases by @abcdmku in pingdotgg/t3code#7856

## New Contributors
* @abcdmku made their first contribution in pingdotgg/t3code#7856

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260822.1159...v0.0.34-nightly.20260822.1160

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260822.1160
ohbentos pushed a commit to ohbentos/t3code that referenced this pull request Aug 23, 2026
# This is the 1st commit message:

fix: render workspace images in chat markdown (pingdotgg#6433)

# This is the commit message pingdotgg#2:

test(desktop): remove redundant release note assertion (pingdotgg#7873)

Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 23, 2026
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
cloudbridgeuy pushed a commit to cloudbridgeuy/t3code that referenced this pull request Aug 23, 2026
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant