Skip to content

test: remove low-signal test files - #8397

Merged
t3-code[bot] merged 1 commit into
mainfrom
test/prune-low-signal-tests
Aug 27, 2026
Merged

test: remove low-signal test files#8397
t3-code[bot] merged 1 commit into
mainfrom
test/prune-low-signal-tests

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

this removes eight complete test files that added maintenance cost without protecting a useful regression boundary.

removals

  • deletes static-markup tests that only froze current tailwind classes and jsx structure
  • deletes tests that transcribed obvious constants, one-line mappings, and generated identifier formatting
  • deletes a web wrapper test that exercised the platform URL constructor through a direct re-export
  • deletes a source-text dependency check that only recognized one exact import spelling

no production code changed. this removes 14 tests and 135 lines across eight files.

verification

before deletion:

  • vp test run <eight removed files> passed, 8 files and 14 tests

after deletion:

  • vp test run packages/client-runtime/src/state/assets.test.ts apps/web/src/components/ui/button.test.tsx passed, 2 files and 7 tests
  • affected web, mobile, server, and shared package typechecks passed
  • server typecheck emitted only existing ts377019 suggestion diagnostics
  • git diff --cached --check passed
  • all 1,030 open pull requests were checked for path conflicts; none touches these files

generated by gpt-5.6-sol with hermes agent.

request provenance


Note

Low Risk
Test-only deletions with no runtime behavior changes; regression coverage drops only for previously low-signal assertions.

Overview
Removes eight entire test files (~135 lines, 14 tests) across mobile, server, web, and shared with no production code changes.

The deleted suites were mostly brittle or low-value: static React markup assertions on Tailwind/class names (StartTruncatedPath, toggle-group), trivial constant/mapping checks (mobileBranding, Attributes, themePreview), a thin URL wrapper test (assetUrls), random ID format checks (previewAutomationClientId), and a string-matching guard on main.tsx / package.json for react-grab imports.

Production helpers and components are unchanged; only test maintenance surface is reduced.

Reviewed by Cursor Bugbot for commit cdaa8fc. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove low-signal test files across mobile, server, web, and shared packages

Deletes 8 test files that covered pure mapping functions, simple ID generation, and structural assertions with limited regression value. Affected files span mobileBranding, Attributes normalization, assetUrls, StartTruncatedPath, previewAutomationClientId, toggle-group, reactGrabBoundary, and themePreview.

Macroscope summarized cdaa8fc.

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.3 KiB 13.3 KiB −11 B (−0.1%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 6.9 KiB +8 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.4 KiB 6.4 KiB −19 B (−0.3%) 7.8 KiB
Codex Live turn WebSocket decoded 55.6 KiB 55.6 KiB −44 B (−0.1%) 66.4 KiB
Codex Live turn messages 11 10 −1 (−9.1%) 21
Claude Total thread wire 13.4 KiB 13.4 KiB 0 B (0.0%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 6.9 KiB −6 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB +6 B (+0.1%) 7.8 KiB
Claude Live turn WebSocket decoded 56.4 KiB 56.4 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 11 11 0 (0.0%) 21

Baseline: a6797b3 · PR result: cdaa8fc · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at cdaa8fc

Macroscope's review found this PR approvable — The PR removes eight test-only files containing 14 low-signal assertions across mobile, server, web, and shared code, while leaving production sources and runtime entry points unchanged. Its only material effect is reduced regression coverage and test-maintenance surface.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@t3-code
t3-code Bot merged commit 73f8cfc into main Aug 27, 2026
22 checks passed
@t3-code
t3-code Bot deleted the test/prune-low-signal-tests branch August 27, 2026 13:28
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 28, 2026
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 29, 2026
## What's Changed
* fix(grok): improve skills, plans, usage, and turn reliability by @t3dotgg in pingdotgg/t3code#8358
* fix(server): recover stale Codex approval callbacks by @luckyPipewrench in pingdotgg/t3code#5195
* test(server): remove duplicate missing worktree test by @t3-code[bot] in pingdotgg/t3code#8252
* fix(server): replay all un-applied events during projection bootstrap by @krutftw in pingdotgg/t3code#7538
* test: remove low-signal test files by @t3-code[bot] in pingdotgg/t3code#8397
* test: prune trivial error and layout tests by @t3-code[bot] in pingdotgg/t3code#8400
* Fix Android adaptive launcher icon by @colonelpanic8 in pingdotgg/t3code#4332
* feat(web): split provider settings into list and editor by @t3dotgg in pingdotgg/t3code#8380
* fix(codex): accept Codex 0.150 account plans by @gsimone in pingdotgg/t3code#8447
* fix(tooling): allow ignored-only staged changes by @juliusmarminge in pingdotgg/t3code#8468
* fix(mobile): keep iOS home header stable by @juliusmarminge in pingdotgg/t3code#8467
* fix(web): stop showing red x summaries for ordinary tool failures by @t3dotgg in pingdotgg/t3code#8395
* fix(mobile): refine Git action toast glass styling by @juliusmarminge in pingdotgg/t3code#8399
* fix(desktop): allow preview automation in agent-created threads by @t3dotgg in pingdotgg/t3code#8483
* test(web): remove redundant cache key test by @t3-code[bot] in pingdotgg/t3code#8484
* fix(release): move nightly schedule to minute 38 by @t3dotgg in pingdotgg/t3code#8509
* fix(web): stabilize the provider settings editor by @t3dotgg in pingdotgg/t3code#8472
* fix(web): open GitHub pull requests in browser when loading fails by @t3dotgg in pingdotgg/t3code#8507
* fix(codex): show sub-agent models by @t3dotgg in pingdotgg/t3code#8502
* feat(analytics): report connected client platforms by @t3dotgg in pingdotgg/t3code#8481
* feat(server): accept PDF, ZIP, and other file uploads up to 50MB by @t3dotgg in pingdotgg/t3code#8235
* feat(web): toggle a thread's pin from the keyboard by @ipanasenko in pingdotgg/t3code#8440
* fix(web): add back button to project settings by @StiensWout in pingdotgg/t3code#8168
* refactor(mobile): compile semantic themes for Uniwind by @juliusmarminge in pingdotgg/t3code#7327
* fix(desktop): Cache Runtime locally on WSL Filesystem, dramatically improving launch times  by @ikifar2012 in pingdotgg/t3code#5769
* fix(mobile): show OpenCode model sources in picker by @juliusmarminge in pingdotgg/t3code#8573
* fix(clients): honor project default models in new threads by @anirudhsama in pingdotgg/t3code#6011
* fix(mobile): show file actions on Android by @none23 in pingdotgg/t3code#8215
* fix(connect): explain DPoP connection failures by @extoci in pingdotgg/t3code#8351
* feat(web): make the sidebar project filter a searchable combobox by @SunkenInTime in pingdotgg/t3code#5931
* fix(server): a draft can retry its first send after a failed bootstrap by @shivamhwp in pingdotgg/t3code#8226
* fix(desktop): stop hidden previews draining battery by @Bil0000 in pingdotgg/t3code#8567
* fix(desktop): oauth popups open from the browser preview by @walid-baharwal in pingdotgg/t3code#8435
* fix(web): keep long task drawers usable on small screens by @shivamhwp in pingdotgg/t3code#8313
* fix(opencode): handle child approvals, stops, and model catalogs by @t3dotgg in pingdotgg/t3code#8480
* fix: make thread auto-settling opt-in by @shivamhwp in pingdotgg/t3code#8321
* fix(web): stop session activity timing test from blocking releases by @t3dotgg in pingdotgg/t3code#8585
* fix(mobile): show composer menus when starting a task by @juliusmarminge in pingdotgg/t3code#8587
* fix(web): show the configured stash shortcut by @UtkarshUsername in pingdotgg/t3code#8437
* feat(web): add toggleable confirmation before unpinning a thread by @UtkarshUsername in pingdotgg/t3code#7313
* fix: restore automatic thread settling defaults by @t3dotgg in pingdotgg/t3code#8596
* fix(mobile): restore composer glass and rounded shadows by @juliusmarminge in pingdotgg/t3code#8597

## New Contributors
* @luckyPipewrench made their first contribution in pingdotgg/t3code#5195
* @krutftw made their first contribution in pingdotgg/t3code#7538
* @colonelpanic8 made their first contribution in pingdotgg/t3code#4332
* @ikifar2012 made their first contribution in pingdotgg/t3code#5769
* @walid-baharwal made their first contribution in pingdotgg/t3code#8435

**Full Changelog**: pingdotgg/t3code@v0.0.35...v0.0.36

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants