fix(web): open provider settings on the Models tab - #8543
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a self-contained one-line UI default change that opens known provider settings on the existing Models tab while preserving the Configuration fallback for unknown drivers. It has no API, data, authentication, billing, or deployment impact. You can add or adjust custom eligibility rules. Learn more. |
Fixes #8521.
Since #8380 every provider opened its editor on the Configuration tab, so set-once plumbing (display name, accent color, env vars, binary path) was the first thing on the Providers page instead of the Models list users actually change.
ProviderInstanceCardnow initialisesactiveTabto"models". The existingvisibleTabguard still forces Configuration for unknown drivers that have no Models tab, so nothing changes for custom fork instances.Screenshots
Checks
vp test run apps/web/src/components/settings/ProviderInstanceCard.test.ts apps/web/src/components/settings/ProviderSettingsPanel.environment.test.tsxvp run typecheckinapps/webMade with Claude Fable 5 in the Claude Code harness through T3 Code.
Note
Low Risk
Single default UI state change with no API, auth, or data-handling impact; unknown-driver fallback behavior is preserved.
Overview
Provider instance editor now opens on the Models tab instead of Configuration, so the Providers page surfaces model visibility/favorites first rather than one-time plumbing (display name, env vars, binary path).
Only the initial
activeTabstate inProviderInstanceCardchanges from"configuration"to"models". The existingvisibleTabrule still pins Configuration whendriverOptionis missing (unknown/custom fork drivers with no Models tab), so that path is unchanged.Reviewed by Cursor Bugbot for commit 4eab817. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Set default tab to
modelsinProviderInstanceCardChanges the initial
activeTabstate in ProviderInstanceCard.tsx fromconfigurationtomodels. The Models tab is now shown first when opening provider settings.Macroscope summarized 4eab817.