Skip to content

chore(deps): bump Electron to 43.4.1 - #8626

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/upgrade-electron-43
Aug 31, 2026
Merged

chore(deps): bump Electron to 43.4.1#8626
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/upgrade-electron-43

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Electron 41 is no longer supported. This moves the desktop app to the supported Electron 43 line without taking the additional Electron 44 breaking changes.

The upgrade updates Electron and its lockfile graph, then removes the obsolete WebSQL storage type that Electron 43 no longer accepts. electron-updater and all other direct dependencies remain unchanged.

Checks:

  • 5 focused desktop and packaging test files, 83 tests
  • desktop typecheck
  • desktop and server production build
  • Electron launch smoke test

Made with GPT-5.6-sol through the Codex harness in T3 Code.


Note

Medium Risk
A two-major Electron bump can surface deprecated APIs or runtime behavior outside the areas covered by tests; the WebSQL removal is a targeted compatibility fix for storage clearing.

Overview
Moves the desktop app from unsupported Electron 41.5.0 to 43.4.1 (supported line, without jumping to Electron 44). The lockfile updates Electron’s install graph (e.g. @electron/get@5.1.0, internal extract-zip).

Preview session cleanup drops websql from clearStorageData in BrowserSession.clearCookies, since Electron 43 no longer accepts that storage type; the matching test expectation is updated. Other direct deps (including electron-updater) are unchanged in this diff.

Reviewed by Cursor Bugbot for commit 9e77068. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump Electron from 41.5.0 to 43.4.1 and remove websql from clearStorageData

  • Updates the Electron dependency in package.json from 41.5.0 to 43.4.1 and refreshes the lockfile.
  • Removes 'websql' from the storages array in BrowserSession.clearCookies in BrowserSession.ts and the matching assertion in BrowserSession.test.ts.
  • Risk: Electron 43 is a major version jump (41 → 43); other deprecated or removed Electron APIs not yet surfaced by tests may cause runtime or build regressions.

Macroscope summarized 9e77068.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79d891e4-0d3a-49e3-a4df-d9c8393ae3aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 29, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR makes a major Electron 41-to-43 runtime upgrade and changes the default preview-session storage cleanup policy by removing WebSQL. Both affect shipped desktop behavior, so the change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 29, 2026
@MatthewFeroz

Copy link
Copy Markdown
Contributor

Independently double-checked this dependency bump.
• Audited T3's Electron API usage against the Electron 42/43 breaking changes
• Confirmed the websql removal is required and no other affected APIs appear to be used
• Verified the lockfile change is limited to Electron's dependency graph
• Ran the full desktop suite: 625 tests passed
• Ran 678 focused GitHub, source-control, and PR integration tests
• Desktop typecheck, server build, desktop build, and Electron launch smoke test passed
• Confirmed electron-updater is unchanged and @clerk/electron supports
Electron 43
I found no blocking regressions. The remaining gap is packaged smoke testing on macOS and Windows; the macOS preview artifact was skipped in Cl. Code-wise, this looks safe to approve.

@juliusmarminge
juliusmarminge merged commit 4a9d2d0 into pingdotgg:main Aug 31, 2026
25 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 1, 2026
## What's Changed
* chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626
* fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922
* feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919


**Full Changelog**: pingdotgg/t3code@v0.0.38-nightly.20260831.1240...v0.0.38-nightly.20260831.1241

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38-nightly.20260831.1241
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 1, 2026
## What's Changed
* Add mobile composer attachment menu with video support by @juliusmarminge in pingdotgg/t3code#8843
* fix(web): restore unified activity logs and composer banners by @t3dotgg in pingdotgg/t3code#8734
* fix(web): address composer banner review follow-ups by @juliusmarminge in pingdotgg/t3code#8850
* fix(web): widen sync banners and simplify the working timer by @juliusmarminge in pingdotgg/t3code#8855
* fix(preview): improve browser recording quality by @maria-rcks in pingdotgg/t3code#8839
* fix(web): mark pull request links as external by @juliusmarminge in pingdotgg/t3code#8856
* fix(mobile): replace Callstack glass with Expo glass by @juliusmarminge in pingdotgg/t3code#8862
* fix(server): skip IDE detection in Claude probes by @yashranaway in pingdotgg/t3code#8634
* chore(macroscope): review diagnostic overrides by @t3-code[bot] in pingdotgg/t3code#8917
* fix(contracts): accept CLI event origins by @nateEc in pingdotgg/t3code#8905
* fix(web): hide invalid slash skill completions by @nateEc in pingdotgg/t3code#8904
* fix(mobile): defer draft navigation until submission completes by @juliusmarminge in pingdotgg/t3code#8914
* chore: disable CodeRabbit review status by @juliusmarminge in pingdotgg/t3code#8933
* Delete app.json by @juliusmarminge in pingdotgg/t3code#8934
* fix(web): show scrollbar for wide markdown tables by @UtkarshUsername in pingdotgg/t3code#8868
* fix(mobile): shimmer active tool rows by @juliusmarminge in pingdotgg/t3code#8932
* chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626
* fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922
* feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919
* fix(web): prevent chat metadata overlap by @MatthewFeroz in pingdotgg/t3code#8851
* fix(server): preserve usage cache outside walked roots by @Lucenx9 in pingdotgg/t3code#8540
* feat(mobile): add native image and PDF previews by @juliusmarminge in pingdotgg/t3code#8959
* fix(server): allow long thread IDs in HTTP routes by @nateEc in pingdotgg/t3code#8898
* fix(shared): preserve Windows shell PATH priority by @UtkarshUsername in pingdotgg/t3code#8748
* fix(web): make WSL settings searchable by @UtkarshUsername in pingdotgg/t3code#8881
* feat(web): add expand/collapse all control to the files surface by @UtkarshUsername in pingdotgg/t3code#8889
* feat(mobile): upload attachments while composing by @juliusmarminge in pingdotgg/t3code#8978
* fix(chat): keep agent activity visible between actions by @maria-rcks in pingdotgg/t3code#8984
* fix(server): isolate remote web session cookies by @Bil0000 in pingdotgg/t3code#8085
* feat(pull-requests): link GitHub references in markdown by @maria-rcks in pingdotgg/t3code#8812
* perf(server): reduce frequency of full tool call output being loaded into memory from db by @t3dotgg in pingdotgg/t3code#8988
* feat(web): add pull request list filters by @maria-rcks in pingdotgg/t3code#8809
* feat(web): search individual settings by detail by @maria-rcks in pingdotgg/t3code#8831
* feat(client): render viewed images in work logs by @maria-rcks in pingdotgg/t3code#8936
* fix(client): use package import for markdown image helpers by @juliusmarminge in pingdotgg/t3code#9010
* test: remove static presentation snapshots by @t3-code[bot] in pingdotgg/t3code#9008
* perf(server): bound snapshot activity payload memory by @t3dotgg in pingdotgg/t3code#9000
* perf(server): cut idle CPU use and stop provider event leaks by @t3dotgg in pingdotgg/t3code#8187
* perf(server): scan only appended transcript bytes for usage summaries by @StiensWout in pingdotgg/t3code#9024
* perf(server): cut chatty tool-update frames by 90% by @Adamulek123 in pingdotgg/t3code#8368
* fix(server): settle threads server-side by @t3dotgg in pingdotgg/t3code#8600
* fix(clients): dedupe skills in composer menus by @Adamulek123 in pingdotgg/t3code#8043
* fix(server): stop OpenCode child sessions by @t3dotgg in pingdotgg/t3code#9005
* perf(web): defer pull request line stats until visible by @Adamulek123 in pingdotgg/t3code#6471
* perf(server): skip full-message reads while streaming by @t3dotgg in pingdotgg/t3code#9032
* perf(client-runtime): halve server config bootstrap traffic by @Adamulek123 in pingdotgg/t3code#8367
* fix(web): align un-settle banner action by @StiensWout in pingdotgg/t3code#9033
* fix(web): block type-to-focus behind open dialogs by @Lucenx9 in pingdotgg/t3code#8139
* feat(shortcuts): copy active thread reference by @maria-rcks in pingdotgg/t3code#8994
* fix(mobile): keep thread scroll bounds current after animations by @juliusmarminge in pingdotgg/t3code#9013
* fix(server): cache project favicon resolution by @willsheldon in pingdotgg/t3code#9080
* feat(claude): add Claude Fable 5.1 model by @q1 in pingdotgg/t3code#9078
* fix(preview): restore recording and macOS rendering after Electron 43 by @StiensWout in pingdotgg/t3code#9001
* feat(desktop): add configurable quit shortcut confirmation by @juliusmarminge in pingdotgg/t3code#9076
* feat(web): open project settings from thread menus by @SunkenInTime in pingdotgg/t3code#8925
* fix(chat): reuse one row for live activity by @maria-rcks in pingdotgg/t3code#9062
* feat(models): discover Claude models from remote manifest by @juliusmarminge in pingdotgg/t3code#9084
* Revert "fix(chat): reuse one row for live activity" by @maria-rcks in pingdotgg/t3code#9096
* fix(web): sync sidebar PR state from open panel by @t3-code[bot] in pingdotgg/t3code#9092
* fix(web): changing projects no longer creates a draft by @extoci in pingdotgg/t3code#9097
* fix(web): keep theme placeholder text dimmer than entered text by @flamboh in pingdotgg/t3code#9104
* fix(web): keep the selected environment when changing projects by @t3dotgg in pingdotgg/t3code#9102

## New Contributors
* @willsheldon made their first contribution in pingdotgg/t3code#9080
* @q1 made their first contribution in pingdotgg/t3code#9078

**Full Changelog**: pingdotgg/t3code@v0.0.37...v0.0.38

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:mac Build an Apple Silicon DMG for this PR on every push. size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants