Skip to content

fix(web): keep agent images collapsed - #9460

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/fix-auto-expanded-images
Sep 3, 2026
Merged

fix(web): keep agent images collapsed#9460
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/fix-auto-expanded-images

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Agent-produced image previews were rendered while their activity row reported aria-expanded=false. This was introduced when image rendering moved outside the disclosure condition; singleton tool-call grouping is unrelated.

This keeps viewed images behind the existing row disclosure and lets image-only activities participate in expansion. The existing click and full-size preview behavior are unchanged.

Before

After

Verification

  • 38 MessagesTimeline tests pass
  • web typecheck passes
  • targeted lint and format checks pass
  • collapsed and expanded states verified in dark and light at 1280×800
  • expanded image preview action verified

Built by gpt-5.6-sol in T3 Code through the Codex harness.


Note

Low Risk
UI-only disclosure logic in the chat timeline; no auth, data, or API changes.

Overview
Fixes a mismatch where agent “viewed image” previews could render on collapsed activity rows (aria-expanded=false) after image rendering was decoupled from row expansion.

Viewed-image previews now render only when the work entry row is expanded. canExpand treats a resolved viewed-image path like other expandable content (command, detail, changed files), so image-only activities show the disclosure chevron and can be toggled. Click-to-expand and full-size preview behavior are unchanged.

Reviewed by Cursor Bugbot for commit 6ee95d2. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix agent viewed images to stay collapsed in PlainWorkEntryRow

Moves the viewed-image path calculation before the expandability check in PlainWorkEntryRow so rows with only a viewed image become expandable. The viewed image now renders only while the row is expanded, keeping agent images collapsed by default. Changes are in MessagesTimeline.tsx.

Macroscope summarized 6ee95d2.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 3, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized UI fix keeps agent images hidden until their work-log row is expanded and preserves an expand affordance for image-only entries. Because it changes the default product presentation of agent images, the default behavior warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit 8bd544c into pingdotgg:main Sep 3, 2026
21 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): send cited messages with Cmd+Enter by @extoci in pingdotgg/t3code#9307
* fix(web): preserve explicit preview navigation URLs by @nateEc in pingdotgg/t3code#8902
* fix(web): prevent loading ssh environments from overriding navigation by @flamboh in pingdotgg/t3code#9168
* fix(mobile): skip unsupported shared settings targets by @Lucenx9 in pingdotgg/t3code#9381
* fix(web): avoid duplicate Antigravity install status by @RakshithBhat03 in pingdotgg/t3code#9419
* fix(composer): mute fast icon when collapsed by @maria-rcks in pingdotgg/t3code#9451
* fix(web): unify skeleton loading animations on one pulse by @maria-rcks in pingdotgg/t3code#9448
* fix(web): prioritize authored pull requests by @maria-rcks in pingdotgg/t3code#9453
* fix(web): make project icons the default by @maria-rcks in pingdotgg/t3code#9457
* fix(server): reuse pr state when settling threads by @maria-rcks in pingdotgg/t3code#9459
* fix(web): keep agent images collapsed by @maria-rcks in pingdotgg/t3code#9460
* fix(web): banner buttons no longer expand the resting composer by @juliusmarminge in pingdotgg/t3code#9452
* fix(web): stop clipping the traits chevron on long Codex effort labels by @zortos293 in pingdotgg/t3code#9433


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1270...v0.0.39-nightly.20260903.1272

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant