test(scripts): keep Windows packaging checks host-portable - #9589
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
b6ddab3 to
5969699
Compare
5969699 to
185fded
Compare
185fded to
9046826
Compare
9046826 to
46488bb
Compare
46488bb to
eeb923a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit eeb923a. Configure here.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The changes are limited to making packaging tests host-portable and extending a filesystem-heavy test's timeout. They affect CI/test execution only and do not alter shipped product behavior or defaults. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
eeb923a to
9682faa
Compare
9682faa to
d044ffa
Compare
d044ffa to
90ffedf
Compare
90ffedf to
11d0075
Compare
Dismissing prior approval to re-evaluate 11d0075
11d0075 to
52f16d1
Compare
The Windows payload fixture uses a text placeholder for t3code.exe. Pin only the native-load probe platform to linux in the three cases that reach it, while leaving host-native paths and real tar, archive, digest, ASAR, and self-containment checks active. The broad Windows lane also runs four filesystem-heavy suites at once. Give the cold pnpm-store dependency scan 120 seconds so it retains its full closure assertions under that load instead of inheriting the 60-second root limit. Build the browser-secret output expectation and sign-macos path match with host-aware separators. Co-Authored-By: Claude Code <noreply@anthropic.com>
52f16d1 to
0c3eaef
Compare

The Windows payload fixture uses a text placeholder for t3code.exe. On a Windows host, the validator tried to run that placeholder for its primary native-load probe and failed before reaching the archive and self-containment assertions. In the broad lane, the cold pnpm-store dependency scan also exceeded the 60-second root timeout while four filesystem-heavy workspace suites ran concurrently.
Pin only the payload probe’s HostProcessPlatform service to Linux in the three affected cases. Host-native paths, real tar extraction, WSL archive and digest validation, ASAR unpacking, and self-containment checks still execute on Windows. Give the dependency scan a focused 120-second budget without weakening its closure assertions. The browser-secret and macOS signing expectations now accept host-native separators too.
Part of the Windows test-suite stack rooted at #9564; the manual Windows lane comes from #9538.
Originally prepared with Claude Fable 5 in Claude Code; finalized with GPT-5.6 Sol in T3 Code.
Note
Low Risk
All changes are test-only; production build and packaging code is unchanged.
Overview
Makes desktop build script tests reliable on Windows CI without weakening what they assert.
Windows payload validation: Three cases that run the primary native-load probe now inject
HostProcessPlatformas"linux"because the fixture’st3code.exeis a text stub that fails when executed on a real Windows host. Tar/archive, ASAR, WSL digest, and self-containment checks still exercise host-native behavior where they don’t depend on that probe.Path portability: The Linux browser-secret staging test builds the expected
--outputpath with Effect’sPathservice instead of a hardcoded POSIX string. The signed macOS build config test accepts/or\in thesign-macos.tspath.CLI external closure: The pnpm-store “finds runtime-external packages on disk” test gets a 120s per-test timeout so a cold filesystem walk doesn’t hit the default limit when the Windows lane runs several heavy suites in parallel.
Reviewed by Cursor Bugbot for commit 0c3eaef. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Make
build-desktop-artifactandcli-external-packagestests host-portableHostProcessPlatformas Linux so host-native load probes run on non-Windows hosts instead of relying on the real host OSbrowser-secrethelper test uses the injectedPathservice to build the expected output path rather than hardcoding slash separators/and\path separatorsMacroscope summarized 0c3eaef.