Repository navigation
Next Steps #3
Description
@masterada @at-wat Just starting a tracking issue, feel free to add anything to this list you think are important! I will also be helping after v3.0.0 is tagged :)
- Create examples
- Move NACK to dedicated pkg. Should top-level just be structure, and each specific topic be their own folder?
- Tests
- Finish README
- Elevator Pitch
- Roadmap/Interceptor Types
- Motivations for Interceptors/why we did it this way
- Architecture/Design Document (in own .md file?)
Activity
Sean-Der commentedon Nov 26, 2020
@aler9 also would love your opinion :)
masterada commentedon Nov 27, 2020
Do we need WASM build in this project? If not, I think we should remove WASM test.
Sean-Der commentedon Nov 27, 2020
@masterada I think WASM tests might actually work with no modifications! What happens if you just remove all exclusions?
pion/webrtcisn't very WASM friendly. Howeverpion/rtpandpion/rtcpshould be just fine. I think it is worth having it work. In the future WASM support could unlock some really interesting stuff.If we can get socket support in the browser we could run Pion in the browser right away! I don't have any concrete plans, but I think it could be something that will suprise us eventually :)
Sean-Der commentedon Nov 27, 2020
What do you think of moving the tests from
pion/webrtcinto here for interceptors? Just trying to find a good mix between bringing the time down to run all the tests without lowering the software quality :)For me
pion/webrtcsits at ~90 seconds, which isn't terrible but we can always do better :)masterada commentedon Nov 27, 2020
Yes, they run, just seemed a bit unnecessary to run tests twice, but doesn't really hurt I guess.
The test in interceptor_test is there to make sure interceptors are properly called everywhere (so it's more of a test for the intergration of interceptors into webrtc), so I think we should leave it there. Tests for specific interceptors can go into this packet (eg: see my nack pr)
Finish basic README