Skip to content

WIP: simplify interface to TWCC 3/4 - #298

Open
jech wants to merge 2 commits into
pion:mainfrom
jech:simplify-twcc
Open

WIP: simplify interface to TWCC 3/4#298
jech wants to merge 2 commits into
pion:mainfrom
jech:simplify-twcc

Conversation

@jech

@jech jech commented Jan 13, 2025

Copy link
Copy Markdown
Member

This is part 3/4 of a multi-package series.

Part 1 is at #297
Part 2 is at pion/webrtc#3002

Please don't merge until the series is complete.

@codecov

codecov Bot commented Jan 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.03%. Comparing base (82bca40) to head (888fadd).
⚠️ Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cc/interceptor.go 0.00% 10 Missing ⚠️
registry.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   71.26%   71.03%   -0.24%     
==========================================
  Files          80       80              
  Lines        4476     4492      +16     
==========================================
+ Hits         3190     3191       +1     
- Misses       1153     1166      +13     
- Partials      133      135       +2     
Flag Coverage Δ
go 71.03% <0.00%> (-0.10%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jech added 2 commits January 13, 2025 18:40
Make Registry.Build take an optional list of extra interceptors
that are added before the ones specified by the registry.
Creates a single interceptor without going through a factory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant