feat: support config hash annotation for StatefulSets and DaemonSets#7025
Open
Parthtiw710 wants to merge 1 commit into
Open
feat: support config hash annotation for StatefulSets and DaemonSets#7025Parthtiw710 wants to merge 1 commit into
Parthtiw710 wants to merge 1 commit into
Conversation
…Sets and DaemonSets Signed-off-by: Parthtiw710 <www.parthtiwari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for automatically annotating configuration hash changes to StatefulSet and DaemonSet workloads in the new
pipedv1Kubernetes plugin.Prior to this PR, config map and secret hash annotation triggers for automatic pod restarts were only applied to
Deploymentworkloads, leaving a placeholder TODO.Key Changes:
annotateConfigHashfunction inpkg/app/pipedv1/plugin/kubernetes/deployment/annotate.goto processStatefulSetandDaemonSetmanifests.annotate_test.goverifying that config-hashes are calculated and injected correctly on both workload types.