Repository navigation
Bound the Mastodon response body read and cancel oversized bodies - #129
Merged
Merged
Conversation
discardBody buffered a chunked body in full with response.text() before checking its size, and left a body with an over-limit content-length unread and open. Read through a stream reader with a byte cap instead, and cancel the body once it is (or declares to be) over the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
discardBodyinsrc/adapters/mastodon/client.tssaid it read the response body only to bound memory, but:content-length(a chunked response), it calledresponse.text(), which buffers the whole body before the size check. An instance (or anything in front of it) streaming a huge body would have it all held in memory.content-lengthover the limit, it returned without reading or cancelling the body, leaving the stream and its connection open.What changed
content-lengthovermaxResponseBytes(default 64 KiB) is cancelled withbody.cancel()without being read.MastodonError(status only, with no body and no token).How it was tested
New tests in
src/adapters/mastodon/client.test.tsmock HTTP at the client boundary with an instrumentedReadableStream(no live instance):content-lengthis cancelled with at most one chunk pulledMastodon responded with HTTP 500Four of the new tests fail against the old code.
just checkpasses.🤖 Generated with Claude Code