Repository navigation
[release-2.17] vtorc: stop passing --cell - #873
Merged
Merged
Conversation
The backport of #805 in #821 also brought along a line from main that passes --cell to vtorc. Vitess v23's vtorc has no --cell flag and won't start with it, which breaks the upgrade from operator v2.16 with Vitess v23 to operator v2.17.1: - With the Immediate update strategy, the operator upgrade rolls vtorc right away. The new Pod crash-loops, and the rollout stays stuck until the cluster moves to Vitess v24. The old Pod keeps running. - With the default External strategy, the same happens when a rollout is released while the cluster is still on Vitess v23. - A vtorc Deployment created while the cluster is on Vitess v23, such as one for a new shard, has no old Pod to fall back on, so that shard runs without vtorc. The flag is optional in Vitess v24: without it, vtorc only logs that it will be required in v25. It belongs on main, which becomes operator v2.18 and pairs with Vitess v25. This restores the file to its v2.17.0 contents. Signed-off-by: Matt Lord <mattalord@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change removing the unsupported vtorc --cell flag.
No open issues 🎉
What changed in this PR
Restores Vitess v23 compatibility on release-2.17 by removing the unsupported --cell flag from operator-managed vtorc deployments.
Changes:
- Stops passing
--cell, preventing vtorc startup failures on Vitess v23. - Preserves Vitess v24 compatibility, where the flag is optional.
| File | Description |
|---|---|
pkg/operator/vtorc/deployment.go |
Removes cell from the generated vtorc flags. |
Review effort: Balanced
mhamza15
approved these changes
Nov 4, 2026
inelpandzic
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backport of #805 in #821 also brought along a line from main that passes
--cellto vtorc. Vitess v23's vtorc has no--cellflag and won't start with it, which breaks the upgrade from operator v2.16 with Vitess v23 to operator v2.17.1:The flag is optional in Vitess v24: without it, vtorc only logs that it will be required in v25. It belongs on main, which becomes operator v2.18 and pairs with Vitess v25. This restores the file to its v2.17.0 contents.