Repository navigation
Conversation
On-behalf-of: @SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <rvasek01@gmail.com>
gman0
commented
Sep 1, 2026
| return fmt.Errorf("getting lease %s/%s: %w", leaseNamespace, leaseName, err) | ||
| } | ||
| lease = found | ||
| lease, err := r.findLeaseByConnection(ctx, c, cc.Name) |
Contributor
Author
There was a problem hiding this comment.
Actually this findLeaseByConnection could have been called something else, and the signature is also weird. It returns error on listing failures, but it can also return nil when the Lease is not found by name. I don't like this can fail in two ways. Will change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how the hearbeat Leases are retrieved, i.e. just find it by matching annotation.