Skip to content

The opacityscale, 'extremes', has constant opacity equal to 1 #4723

Description

@empet

The function createWave()

function createWave(n, minOpacity) {
generates an opacityscale with all opacities equal to 1, because:

 Math.max(1, Math.min(0, v)) // line 27

is 1 for any v.

Replacing it by:

 Math.min(1, Math.max(0, v)) 

removes the actual drawback, and leads to a non-constant opacityscale.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething broken

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions