Color dependencies cause initial import to break

[mtgraves]

The newest versions of your dependencies color-alpha, color-normalize, color-parse, and color-rgba cause me to not even be able to import plotly into my react apps via:

import Plotly from “plotly.js”;

The error thrown is “Typeerror: rgba is not a function”.

When I roll back to a last known working set of these deps (based on another recent react project) I do not experience this and the plotly library works fine.

Working versions:
color-alpha 1.0.4
color-normalize: 1.5.0
color-parse: 1.3.8
color-rgba: 2.1.1

Newest versions of the above cause initial import issue as described above.

[archmoj]

Which version of plotly.js you are using?

[mtgraves]

Which version of plotly.js you are using?

1.55.2

[archmoj]

v1.56.0 is just out.
Could you please upgrade and see if the problem insists?

[mtgraves]

v1.56.0 is just out.
Could you please upgrade and see if the problem insists?

Just upgraded and yes the problem persists.

[archmoj]

A couple of questions:
What is last version of plotly.js that works fine for you?
Have you tried using plotly.js-dist which has no dependency? https://www.npmjs.com/package/plotly.js-dist

[matthiaskoenig]

Having the same issues within a vue app.

[archmoj]

Having the same issues within a vue app.

Which plotly.js version you could use without a problem?

[mtgraves]

It’s not the plotly version. It’s the version of those color dependencies I mentioned in the original post. They have changed something about their libraries which breaks plotly.

[archmoj]

Could you please tell us more about the error message e.g. line number or other info that could help us debug?

[matthiaskoenig]

I can confirm that. Immediatly after the color updates my build broke on the weekend.
Fixed it by fixing

    "color-normalize": "1.5.0",
    "color-rgba": "2.1.1",
    "color-parse": "1.3.8",

With the 1.56 release this broke again. So workaround for now is

    "color-normalize": "1.5.0",
    "color-rgba": "2.1.1",
    "color-parse": "1.3.8",
    "plotly.js": "1.55.2",

[archmoj]

@dy any idea what the source of the problem is?

[archmoj]

@matthiaskoenig on your repo could you replace plotly.js with plotly.js-dist "v1.56.0" which has no dependency?

[dy]

color-* modules now support native ESM entries, as well as commonjs. That in some reason causes troubles in plotly browserify pipeline, which is unexpected. I suspect that is react app webpack config trouble - in some reason that switched to ESM entry and treats it wrong. Some insight to the problem webpack/webpack#4674

…

On Wed, Sep 30, 2020 at 8:49 PM Mojtaba Samimi ***@***.***> wrote: @matthiaskoenig <https://github.com/matthiaskoenig> on your repo could you replace plotly.js with plotly.js-dist "v1.56.0" which has no dependency? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5182 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACJII55CJFWFHD4E2PM643SIPG3HANCNFSM4R7QJA3Q> .

[archmoj]

color-* modules now support native ESM entries, as well as commonjs. That is some reason cause troubles in plotly browserify pipeline, which is unexpected.
…
On Wed, Sep 30, 2020 at 8:49 PM Mojtaba Samimi @.***> wrote: @matthiaskoenig https://github.com/matthiaskoenig on your repo could you replace plotly.js with plotly.js-dist "v1.56.0" which has no dependency? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5182 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJII55CJFWFHD4E2PM643SIPG3HANCNFSM4R7QJA3Q .

@dy Thanks for the insight.
Are you going to address this issue in color* dependencies?
Or you suggest downgrading (pinning down the versions) for now?