Skip to content

Updatemenus toggle buttons via args2 - #4305

Merged
etpinard merged 2 commits into
masterfrom
updatemenus-toggle-via-args2
Oct 25, 2019
Merged

Updatemenus toggle buttons via args2#4305
etpinard merged 2 commits into
masterfrom
updatemenus-toggle-via-args2

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

resolves #4042

example: https://codepen.io/etpinard/pen/WNNOQoj

cc @archmoj - this is the last feature required for v1.51.0

- this set of arguments is passed the set button `method`
  when the button is in the active state.
@etpinard etpinard added this to the v1.51.0 milestone Oct 25, 2019
@etpinard

Copy link
Copy Markdown
Contributor Author

... and cc @alexcjohnson who asked for this feature.

@archmoj

archmoj commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

Looking pretty good to me.
I am not sure about 'args2' naming though.
What about using arglist or extraargs?

@etpinard

Copy link
Copy Markdown
Contributor Author

I am not sure about 'args2' naming though.

Why not, we have axis, axis2?

@archmoj

archmoj commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

OK. Resolved.

@archmoj

archmoj commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

Nicely done.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "toggle legend" button

2 participants