Repository navigation
Let a session asked to ship a named plan start Ship - #726
Closed
anton-matosov wants to merge 11 commits into
Closed
anton-matosov wants to merge 11 commits into
anton-matosov wants to merge 11 commits into
Conversation
The bridge test and the IWE workflow skills spec moved since the plan was written; re-locate both anchors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Drop disable-model-invocation from iwe-ship and narrow its description to a request that names a plan to ship or cancel, or a release to cut. Step 1 quotes an approval a coordinator relays from the user the same way as one the user typed. The bridge tests now expect the gated iwe-ship-all denied and iwe-ship left out of the deny map. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Bun reads an argument that does not start with ./ or / as a name filter, so the plan's bun test command matched no file. Prefix it with ./ in Task 1 and Verification. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Now that iwe-ship is model-invocable, Explore's rules forbid loading it or dispatching iwe-shipper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
The explicit-only workflow agents note now lists any session asked to ship a named plan as a Ship starter, gates only the two coordinators, lets a coordinator relay the user's approvals to Ship, and keeps "drop the gate" rejected for the coordinators alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7BhLtmRst3iA2UZ832Mse
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Don't after big purge of AI slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A session asked in plain words to ship a named plan can now load
/agentdev:iwe-ship. Before, only a typed command could start it. Ship stillruns as a fresh
iwe-shippersubagent whose prompt carries only the plan key,the operation, and approvals quoted verbatim. The
iwe-ship-allandiwe-implement-allcoordinators stay explicit-only. This implements Tasks 1–3of the plan
docs/knowledge/data/plans/20261102-model-invocable-ship.md.What Changed
iwe-shipskill: dropsdisable-model-invocation. Its description nowmatches only a request that names a plan to ship or cancel, or a release to
cut. Step 1 quotes an approval that a coordinator session relays from the user
the same way as one the user typed.
iwe-shipdenied now expect the gated
iwe-ship-alldenied, andiwe-shipabsent fromthe bridge's deny map.
iwe-exploreskill: a new rule says Explore never loads/agentdev:iwe-shipor dispatchesiwe-shipper, even when an answer leavesa plan apparently complete.
explicit-only-workflow-agentsarchitecture note:coordinators only.
bun testcommand now takes a./path, because Bun reads anunprefixed path as a name filter and runs nothing. A revision evaluator
approved this change.
Why
The gate exists to keep conversation context out of Ship. Ship already gets
that from always running as a fresh subagent with a conversation-free prompt.
With the gate in place, a coordinator session that asks another session to ship
a plan is refused, and the user has to type the command in that session. A
narrow description and an explicit Explore rule now handle the stray-start risk
the gate used to guard against.
Verification
disable-model-invocation: trueputback into
iwe-ship/SKILL.md, the two changed config-hook tests fail(27 pass, 2 fail). Without it, all 29 pass.
Reviewer Handoff
models, a plain prompt to ship a named plan loads
iwe-shipand dispatchesone
iwe-shipperwhose prompt carries only the plan key, the operation, andquoted approvals. A rehearsal on Claude Code 2.1.318 behaved this way; the
OpenCode half has not been run.
/agentdev:iwe-exploreon both harnesses,a partial answer that leaves a plan apparently complete loads no Ship or
Implement skill and dispatches no
iwe-shipper. A rehearsal on Claude Codebehaved this way. In one sentence it named "Implement" as a way to record
evidence, which is worth judging against the "names a next step other than
Implement" scenario.
main(8 commits behind, allunrelated dependency updates;
git merge-treereports a clean merge)./agentdev:update-branch.Related
docs/knowledge/data/plans/20261102-model-invocable-ship.mddocs/knowledge/data/plans/20261031-model-invocable-implement.mdGenerated by Claude Code