Skip to content

feat: Manifest v2 #514

Closed
6 of 6 issues completed
Closed

Description

@piotr-roslaniec
  • Contains breaking changes
  • feat!: Manifest v2 #541
  • Next steps and other considerations
    • Implementing property-based testing/fuzzing for the JSON/HTML inputs
    • More expansive suite of test fixtures
    • Validate Manifest building DevEx with users
    • Update developer docs

Activity

  1. piotr-roslaniec commented on Mar 6, 2025

    @piotr-roslaniec
    ContributorAuthor

    Comment on the current status of the work:

    • With changes from feat: Support advanced response matching in Manifest #518, the predicates are used to test the validity of the values extracted from the notary response. However, predicates are not used for filtering. As a result, we are returning not just the values described by the predicates but other values.
    • For example: Let's say a predicate describes an array that contains a "TEST" string. All the following values (arrays) are therefore considered as valid and will be returned entirely: ["TEST"], ["TEST", "OTHER"], ["TEST", "OTHER_1", ... "OTHER_N"]
    • Should we use predicates to enable value filtering? If we do, all of the three values above would be reduced to ["TEST"]
  2. added theissue type on Mar 7, 2025
  3. piotr-roslaniec commented on Mar 12, 2025

    @piotr-roslaniec
    ContributorAuthor

    Removed superfluous sub-issues. Created: #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions