feat: support raw transaction - #43
Closed
cbrzn wants to merge 1 commit into
Closed
Conversation
krisbitney
suggested changes
Mar 13, 2023
krisbitney
left a comment
krisbitney
left a comment
Contributor
There was a problem hiding this comment.
I don't think signing and sending raw transactions should be automated as part of sendTransaction. I think it should be a conscious choice available to advanced users. Could you add a separate method for sendRawTransaction?
Contributor
Author
nice point - will do ser |
Contributor
Author
|
this has been implemented in the provider plugin :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support of
eth_sendRawTransactionmethod for signers that are not wallet. now we are able to support transactions from wallets (like metamask) and also jsonrpc provider + signer (withnew Wallet(..)) - used mostly in scriptsalso, two minor changes:
ethers-rs(instead of fetching it from github, this fixed the problem ofunreachable..)ethers-utilswrapper (chore: move ethers utils to its own package #35)blocked by #42