feat: allow running workflows using cli command - #903
Merged
Conversation
Niraj-Kamdar
marked this pull request as draft
June 8, 2022 16:41
Contributor
|
now that this is implemented, would it make sense to close PR #725 ? |
Contributor
|
Yes @cbrzn, will close that PR |
Niraj-Kamdar
marked this pull request as ready for review
June 10, 2022 16:23
Running Recipe just after starting test-env doesn't guarantee all the necessary services has started and since test-env-js comes with awaiter that makes surethe services has started, it's better to test it in jest.
Niraj-Kamdar
requested review from
namesty,
nerfZael and
ramilexe
as code owners
June 18, 2022 01:47
cbrzn
reviewed
Jun 20, 2022
cbrzn
reviewed
Jun 20, 2022
cbrzn
reviewed
Jun 20, 2022
cbrzn
reviewed
Jun 20, 2022
cbrzn
reviewed
Jun 20, 2022
cbrzn
reviewed
Jun 20, 2022
Co-authored-by: Cesar Brazon <cesarbrazon10@gmail.com>
Co-authored-by: Cesar Brazon <cesarbrazon10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Changelog
Next steps