Replace Nullable with Option in assemblyscript - #944
Merged
Conversation
fetsorn
changed the title
fetsorn
marked this pull request as ready for review
June 23, 2022 16:42
fetsorn
requested review from
Niraj-Kamdar,
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
June 23, 2022 16:42
dOrgJelli
approved these changes
Jun 23, 2022
This was referenced Aug 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces custom Nullable type with Option type from as-container. Resolves #809.
Recap:
We want to represent values which could be "null". Assemblyscript has nullable reference types, e.g. "string | null", but does not support nullable basic types, e.g. "u32", so we wrap primitives in a custom Nullable type, like "Nullable".
This PR wraps basic types in an Option container, like "Option.Some(10)" and "Option.None()". The Option container comes from has a robust implementation and a rust-inspired interface, similar to the Result type we are already using.
This PR does not wrap reference types in Option, they are still implemented as " | null" because " | null" allows for optional fields in the the input arguments to the bindings. Option does not allow optional fields, all missing arguments have to be written as Option.None<>().