Repository navigation
fix(l10n): extract hard-coded Flutter UI strings into ARB - #426
Open
blacktea1891 wants to merge 4 commits into
Open
blacktea1891 wants to merge 4 commits into
blacktea1891 wants to merge 4 commits into
Conversation
blacktea1891
added a commit
to blacktea1891/absorb
that referenced
this pull request
Oct 14, 2026
Preserve upstream authentication settings, deferred library counts, BookOrbit features, and all extracted Flutter localization strings. Resolve admin navigation by retaining Authentication and localizing both Server logs labels.
blacktea1891
added a commit
to blacktea1891/absorb
that referenced
this pull request
Oct 14, 2026
Source tree matches the candidate PR merge exactly except for this temporary validation workflow. Run dependency resolution, localization generation, regression tests, changed-file analysis, and debug APK build before updating the original PR branch.
Keep all upstream features, the iOS Whisper GPU repair, and all 66 extracted Flutter localization strings. Resolve admin navigation by retaining Authentication and localizing both Server logs labels. Flutter 3.47.7 validation passed: dependency resolution, localization generation, 4 localization regression tests, changed-file static analysis, and Android debug APK build. https://github.com/blacktea1891/absorb/actions/runs/38488798572 Later upstream additions only changed the Whisper GPU workflow, iOS precompiled Metal resource, and version/beta markers; localization and application behavior source tested by the run is unchanged.
Retain upstream 1.12.1+300, including BookOrbit reading shelves, EPUB3 narration, Siri, and smart scopes. Resolve the home screen conflict by retaining the upstream hero shelf refactor and moving the localized resume hint into the shared shelf builder. Preserve all 66 extracted English strings and regression tests. Tree verified byte-for-byte against the local Git three-way merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move 66 previously hard-coded English UI strings into app_en.arb and replace their Flutter call sites with the existing AppLocalizations API.
This covers 12 Flutter source files, including:
Placeholder metadata is included for strings with dynamic values.
Why
Some user-facing text still appears in English when another app language is selected, because the strings are not exposed to the Flutter localization system.
Extracting them into the English source ARB makes them available to all supported languages through the existing Crowdin workflow.
Changes
Existing English source entries are unchanged. No translated ARB files are modified; translations can follow through Crowdin.
Testing
Validated in GitHub Actions: PR1 Flutter Validation — successful run.
The validation workflow lives only on a temporary test branch. Its source tree was checked against this PR branch; the only difference is the temporary GitHub Actions workflow file.
No manual device-level UI testing was performed.
Out of scope
Related translation contribution discussion: #425 (not closed by this PR).
This is a focused first step in making remaining UI strings available to community translators.