Repository navigation
feat(iOS): export downloaded audio with AirDrop and Save to Files - #429
Draft
Sammyjoyplayz wants to merge 1 commit into
Draft
Sammyjoyplayz wants to merge 1 commit into
Sammyjoyplayz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloaded iOS audiobooks and podcast episodes stay inside Absorb's App Group, so users cannot send the downloaded audio through AirDrop or browse it in Files. This adds Downloads > More > Export audio files for completed audio downloads. It opens the iOS share sheet with every original track, letting users choose AirDrop or Save to Files. Saved copies remain after the download is removed in Absorb.
The export checks that every track is present, nonempty, and readable before sharing, and reports a localized error instead of exporting an incomplete book. File URLs preserve the downloaded filenames and avoid loading audiobook bytes into Dart memory. The action uses the existing iPad popover anchor and prevents overlapping share requests. Playback files remain in the App Group used by the widget, and legacy Documents downloads also work. No new dependency or storage migration is needed.
Validation with the repository's pinned Flutter 3.47.0:
flutter test --no-pub test/download_export_service_test.dart: 10 tests passed. Coverage includes App Group and Documents paths, multiple tracks in playback order, missing chapters, empty downloads, zero-byte files, invalid paths, a 1 GB file, cancellation, and native errors followed by retry.flutter analyze --no-pub lib/services/download_export_service.dart lib/screens/downloads_screen.dart test/download_export_service_test.dart: no issues.git diff --check: passed.This is a draft because native iOS validation is still pending. The available Mac was unreachable over SSH, so an Xcode build and device transfers could not be checked.
Before marking ready for review: