Conversation
These were pre-existing repo-wide lint failures (not introduced by the client expansion) that blocked the PR's Test Go and Test Python Client jobs: - errcheck: ignore close/remove error returns in webview.go, devicelab_ios/ setup.go, wda/runner.go, flutter/wrapper.go, simulator/recording.go - staticcheck (ST1005): drop trailing punctuation from a build.go error string - unused: remove dead waitKeyboardHidden in uiautomator2/keyboard.go - ruff (S607): noqa on subprocess.run(["adb", ...]) in the animation test The TypeScript client job and Python mypy/pytest already passed.
e2e-android: Run #16
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the pre-existing repo-wide lint fixes onto their own stacked branch on top of the client-expansion PR:
These unblock the
Test GoandTest Python ClientCI jobs. The TypeScript client job and Python mypy/pytest already passed.Test plan
golangci-lint run ./...clean (node_modules excluded)ruff check maestro_runner testspasses🤖 Generated with opencode