Repository navigation
chore(deps): drop vulnerable docker/docker dependency - #7447
Conversation
WalkthroughThis PR updates ChangesGo Module Dependency Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
1-3:⚠️ Potential issue | 🔴 Critical | 🏗️ Heavy liftdocker/docker is not fully removed—still present transitively (v27.1.1+incompatible)
Even though
github.com/docker/dockeris not ingo.modorgo.sum, it still appears in the module graph/build list asgithubproxy.fjygbaifeng.eu.org/docker/docker v27.1.1+incompatible, pulled bygithubproxy.fjygbaifeng.eu.org/ory/dockertest/v3@v3.12.0andgithubproxy.fjygbaifeng.eu.org/praetorian-inc/fingerprintx@v1.1.15. Update dependencies sogo mod graph | rg github.com/docker/dockerreturns no matches.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` around lines 1 - 3, The project still pulls github.com/docker/docker v27.1.1+incompatible transitively via github.com/ory/dockertest/v3 and github.com/praetorian-inc/fingerprintx; update those dependencies to versions that no longer depend on docker/docker (or replace them with maintained forks). Specifically, bump ory/dockertest/v3 and praetorian-inc/fingerprintx to newer releases that removed the docker/docker dependency (or switch to compatible alternatives), then run go mod tidy and verify with go mod graph | rg github.com/docker/docker to ensure no matches remain; update go.mod accordingly and commit the resulting go.sum changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 127-128: The module graph still pulls the vulnerable
github.com/docker/docker despite bumping
github.com/testcontainers/testcontainers-go; inspect go mod graph to find which
consumers (e.g., github.com/ory/dockertest/v3 and
github.com/praetorian-inc/fingerprintx) bring in github.com/docker/docker, then
either upgrade those modules to versions that drop or upgrade the docker
dependency or add a go.mod replace directive to point github.com/docker/docker
to a fixed upstream (or to moby/moby at a safe version) so the CVE is removed;
after changing versions or adding a replace, run dependency resolution (go get
with the chosen versions and go mod tidy) and re-check go mod graph to confirm
github.com/docker/docker is no longer present.
---
Outside diff comments:
In `@go.mod`:
- Around line 1-3: The project still pulls github.com/docker/docker
v27.1.1+incompatible transitively via github.com/ory/dockertest/v3 and
github.com/praetorian-inc/fingerprintx; update those dependencies to versions
that no longer depend on docker/docker (or replace them with maintained forks).
Specifically, bump ory/dockertest/v3 and praetorian-inc/fingerprintx to newer
releases that removed the docker/docker dependency (or switch to compatible
alternatives), then run go mod tidy and verify with go mod graph | rg
github.com/docker/docker to ensure no matches remain; update go.mod accordingly
and commit the resulting go.sum changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ee37b5ab-1b53-4f54-83e8-72cd0747cd88
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/testcontainers/testcontainers-go v0.42.0 | ||
| github.com/testcontainers/testcontainers-go/modules/mongodb v0.42.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify testcontainers-go v0.42.0 removes docker/docker dependency
# Check if v0.42.0 exists
curl -s "https://api.github.com/repos/testcontainers/testcontainers-go/releases" | jq -r '.[].tag_name' | head -20
# Verify the dependency tree after update to confirm docker/docker is removed
go mod download github.com/testcontainers/testcontainers-go@v0.42.0 2>/dev/null && \
go mod graph | grep -i 'docker/docker' || echo "docker/docker not found in dependency graph (expected)"Repository: projectdiscovery/nuclei
Length of output: 332
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Check whether testcontainers-go v0.42.0 exists =="
go list -m -versions github.com/testcontainers/testcontainers-go
echo
echo "== Confirm resolved version in this repo =="
go list -m -f '{{.Version}}' github.com/testcontainers/testcontainers-go
echo
echo "== Find all docker/docker occurrences in module graph =="
go mod graph | rg -n 'github\.com/docker/docker'
echo
echo "== Explain why github.com/docker/docker is in the graph =="
go mod why -m github.com/docker/docker || trueRepository: projectdiscovery/nuclei
Length of output: 1087
testcontainers-go v0.42.0 exists, but it doesn’t eliminate docker/docker from the module graph
github.com/testcontainers/testcontainers-go v0.42.0is a valid release and the repo resolves it tov0.42.0.github.com/docker/dockeris still present ingo mod graph(e.g., viagithubproxy.fjygbaifeng.eu.org/ory/dockertest/v3@v3.12.0andgithubproxy.fjygbaifeng.eu.org/praetorian-inc/fingerprintx@v1.1.15), with no indication it was removed by thetestcontainers-gobump.- Update the dependency chain (or clarify the mitigation) so the CVE’s vulnerable
docker/dockerversion is actually removed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 127 - 128, The module graph still pulls the vulnerable
github.com/docker/docker despite bumping
github.com/testcontainers/testcontainers-go; inspect go mod graph to find which
consumers (e.g., github.com/ory/dockertest/v3 and
github.com/praetorian-inc/fingerprintx) bring in github.com/docker/docker, then
either upgrade those modules to versions that drop or upgrade the docker
dependency or add a go.mod replace directive to point github.com/docker/docker
to a fixed upstream (or to moby/moby at a safe version) so the CVE is removed;
after changing versions or adding a replace, run dependency resolution (go get
with the chosen versions and go mod tidy) and re-check go mod graph to confirm
github.com/docker/docker is no longer present.
nuclei 3.9.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed ### 🎉 New Features * Added support for protocol redirects by @Mzack9999 in projectdiscovery/nuclei#7296 * Added impacket integration by @Mzack9999 in projectdiscovery/nuclei#7356 * Added wmi, tsch, scmr, and dcom helper modules for JS by @dwisiswant0 in projectdiscovery/nuclei#7388 * Added mirroring of -config, -report-config, and -dashboard flags for SDK callers by @ShubhamRasal in projectdiscovery/nuclei#7393 ### 🐞 Bug Fixes * Fixed DNS variables resolving issue by @Mzack9999 in projectdiscovery/nuclei#7379 * Fixed expressions to prefer exact placeholders over expressions by @dwisiswant0 in projectdiscovery/nuclei#7397 * Fixed an issue in JS where runtimes that outlive the interrupt grace period are not abandoned, by @Mzack9999 in projectdiscovery/nuclei#7378 * Fixed an issue in reporting/jira where status-not was not matched against the transition target status name by @knakul853 in projectdiscovery/nuclei#7361 * Fixed runner to write unsigned-templates warning (WRN) to stderr by @ChrisJr404 in projectdiscovery/nuclei#7371 * Fixed `InternalEvent` access serialization in interactsh by @dwisiswant0 in projectdiscovery/nuclei#7322 * Fixed workflow to ensure context is properly propagated to child and race steps by @dwisiswant0 in projectdiscovery/nuclei#7383 * Fixed reporting/gitlab by bumping client-go to v1.9.1 and widening IDs to int64 by @ShubhamRasal in projectdiscovery/nuclei#7398 * Fixed memogen to skip context correctly and auto-push scope to upstream by @Mzack9999 in projectdiscovery/nuclei#7419 * Fixed a slice-bounds panic in telnetmini's ParseNTLMResponse when handling truncated NTLM challenges by @tejgokani in projectdiscovery/nuclei#7425 * Fixed SMBv1 probing in JS to occur after SMB2 negotiation by @dwisiswant0 in projectdiscovery/nuclei#7430 * Fixed templates to reject unknown fields when loading JSON templates by @tejgokani in projectdiscovery/nuclei#7453 * Fixed persistence of QueryAuthStrategy parameters in ApplyAuthStrategy by @akhilesharora in projectdiscovery/nuclei#7410 * Fixed loader to warn when templates are excluded by `.nuclei-ignore` tags by @dogancanbakir in projectdiscovery/nuclei#7452 ### Other Changes * Splitted exact matches and pattern handling in catalog for improved performance by @mikhail5555 in projectdiscovery/nuclei#7340 * Updated README_PT-BR.md to reflect current project description and features by @gugacyber in projectdiscovery/nuclei#7405 * Fixed broken cloud scanning link by @dogancanbakir in projectdiscovery/nuclei#7413 * Bumped pdsec modules + govaluate/aurora migration by @dogancanbakir in projectdiscovery/nuclei#7414 * Dropped vulnerable docker/docker dependency by @dogancanbakir in projectdiscovery/nuclei#7447 * Used path-aware filesystem containment checks by @dwisiswant0 in projectdiscovery/nuclei#7420 * Centralized runtime session handling by @dwisiswant0 in projectdiscovery/nuclei#7449 ## New Contributors * @ChrisJr404 made their first contribution in projectdiscovery/nuclei#7371 * @gugacyber made their first contribution in projectdiscovery/nuclei#7405 * @akhilesharora made their first contribution in projectdiscovery/nuclei#7410 * @tejgokani made their first contribution in projectdiscovery/nuclei#7425 **Full Changelog**: https://github.com/projectdiscovery/nuclei/compare/v3.8.0...v3.9.0</pre> <p>View the full release notes at <a href="https://github.com/projectdiscovery/nuclei/releases/tag/v3.9.0">https://github.com/projectdiscovery/nuclei/releases/tag/v3.9.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!11229
Bumps
gozero(now onmoby/moby/client) andtestcontainers-goto v0.42.0, removinggithubproxy.fjygbaifeng.eu.org/docker/dockerfrom the dependency tree entirely.Fixes #7442.
Summary by CodeRabbit