Skip to content

Loop detection could be done in message/term reference instead of pattern (?) #277

Open

Description

@Pike

When looking at @spookylukey's evaluator, I noticed that the dirty-handling is done in pattern.

That's on a pretty hot code path.

Could we do that in message reference and term reference instead?

Activity

  1. stasm commented on Aug 17, 2018

    @stasm
    Contributor

    I added it in Pattern to make this possible:

    open-foo = Open foo
        .accesskey = O
        .tooltip = Press {open-foo.accesskey} to open a Foo.
  2. Pike commented on Aug 17, 2018

    @Pike
    ContributorAuthor

    Right, it might be a bit trickier to get right. We'd need to keep open-foo, open-foo[var] and open-foo.bar distinct.

  3. spookylukey commented on Aug 18, 2018

    @spookylukey

    @Pike - and also remember the fallback logic that happens when some attributes/variants are missing. I believe I added tests for those conditions, perhaps only in my compiler branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions